linux-kernel - Re: [PATCH] staging: lustre: lustre: ptlrpc: Fix space required

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 30 Aug 2014 11:56:20 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Hema Prathaban <hemaklnce@...il.com>
Cc:	devel@...verdev.osuosl.org, oleg.drokin@...el.com,
	andreas.dilger@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: lustre: lustre: ptlrpc: Fix space required

On Thu, Aug 21, 2014 at 06:59:07PM +0530, Hema Prathaban wrote:
> This patch fixes the checkpatch.pl issue
> Error: Required space after " '+' ',' '=' '(' ' if' "
> 
> Signed-off-by: Hema Prathaban <hemaklnce@...il.com>
> ---
>  drivers/staging/lustre/lustre/ptlrpc/client.c       |  2 +-
>  drivers/staging/lustre/lustre/ptlrpc/events.c       |  4 ++--
>  drivers/staging/lustre/lustre/ptlrpc/import.c       |  8 ++++----
>  drivers/staging/lustre/lustre/ptlrpc/llog_client.c  | 16 ++++++++--------
>  drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c |  6 +++---
>  drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c     |  2 +-
>  drivers/staging/lustre/lustre/ptlrpc/sec_config.c   |  6 +++---
>  drivers/staging/lustre/lustre/ptlrpc/sec_null.c     |  2 +-
>  drivers/staging/lustre/lustre/ptlrpc/service.c      |  2 +-
>  9 files changed, 24 insertions(+), 24 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/client.c b/drivers/staging/lustre/lustre/ptlrpc/client.c
> index 8fa9b71..a327d19 100644
> --- a/drivers/staging/lustre/lustre/ptlrpc/client.c
> +++ b/drivers/staging/lustre/lustre/ptlrpc/client.c
> @@ -289,7 +289,7 @@ static void ptlrpc_at_adj_net_latency(struct ptlrpc_request *req,
>  	at = &req->rq_import->imp_at;
>  
>  	/* Network latency is total time less server processing time */
> -	nl = max_t(int, now - req->rq_sent - service_time, 0) +1/*st rounding*/;
> +	nl = max_t(int, now - req->rq_sent - service_time, 0) + 1/*st rounding*/;
>  	if (service_time > now - req->rq_sent + 3 /* bz16408 */)
>  		CWARN("Reported service time %u > total measured time "
>  		      CFS_DURATION_T"\n", service_time,
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/events.c b/drivers/staging/lustre/lustre/ptlrpc/events.c
> index c3ec21d..9f5af45 100644
> --- a/drivers/staging/lustre/lustre/ptlrpc/events.c
> +++ b/drivers/staging/lustre/lustre/ptlrpc/events.c
> @@ -186,7 +186,7 @@ void client_bulk_callback(lnet_event_t *ev)
>  	if (CFS_FAIL_CHECK_ORSET(OBD_FAIL_PTLRPC_CLIENT_BULK_CB, CFS_FAIL_ONCE))
>  		ev->status = -EIO;
>  
> -	if (CFS_FAIL_CHECK_ORSET(OBD_FAIL_PTLRPC_CLIENT_BULK_CB2,CFS_FAIL_ONCE))
> +	if (CFS_FAIL_CHECK_ORSEuT(OBD_FAIL_PTLRPC_CLIENT_BULK_CB2, CFS_FAIL_ONCE))

You obviously did not compile this code as it breaks the build :(

Please _always_ test build your patches, don't force others to find
errors like this, it's a huge waste of time on my end when it happens...

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/