linux-kernel - Re: [PATCH] staging: comedi: usbdux: fix sparse endianness warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+jnaaX9OsaAGO6MUjSLOoLE57E-egXd2VSmJ7irTOeCe6iuDw@mail.gmail.com>
Date:	Sun, 31 Aug 2014 14:09:49 -0500
From:	Chase Southwood <chase.southwood@...il.com>
To:	Ian Abbott <abbotti@....co.uk>
Cc:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: comedi: usbdux: fix sparse endianness warnings

On Sat, Aug 30, 2014 at 5:40 AM, Ian Abbott <abbotti@....co.uk> wrote:
>
> That seems fine.  Perhaps the variable 'p' in usbdux_ao_insn_write() should
> also be of type '__le16 *'?
>

You're entirely correct.  I had seen this in the output from Sparse,
but for some reason at first glance I had convinced myself that the
fix would be more complicated than it is.  I'll get a patch out with a
Suggested-by: tag for you very soon.

Thanks,
Chase

> Reviewed-by: Ian Abbott <abbotti@....co.uk>
>
> --
> -=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk>        )=-
> -=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/