lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 31 Aug 2014 23:40:29 +0300 From: Ramon Fried <ramon.fried@...il.com> To: gregkh@...uxfoundation.org, ganesanr@...adcom.com Cc: jchandra@...adcom.com, linux-kernel@...r.kernel.org, Ramon Fried <ramon.fried@...il.com> Subject: [PATCH] staging: netlogic: Fix checkpatch.pl warning This patch fixes the following checkpatch.pl warning: WARNING: Possible unnecessary 'out of memory' message #116: FILE: ./xlr_net.c:116: + if (!skb) { + pr_err("SKB allocation failed\n"); Signed-off-by: Ramon Fried <ramon.fried@...il.com> --- drivers/staging/netlogic/xlr_net.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c index f8120fe..3f9c5ad 100644 --- a/drivers/staging/netlogic/xlr_net.c +++ b/drivers/staging/netlogic/xlr_net.c @@ -112,10 +112,8 @@ static inline unsigned char *xlr_alloc_skb(void) /* skb->data is cache aligned */ skb = alloc_skb(XLR_RX_BUF_SIZE, GFP_ATOMIC); - if (!skb) { - pr_err("SKB allocation failed\n"); + if (!skb) return NULL; - } skb_data = skb->data; skb_put(skb, MAC_SKB_BACK_PTR_SIZE); skb_pull(skb, MAC_SKB_BACK_PTR_SIZE); -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists