linux-kernel - Re: [PATCH] staging: netlogic: fixed checkpatch.pl styling warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140831003220.GA24828@kroah.com>
Date:	Sat, 30 Aug 2014 17:32:20 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Ramon Fried <ramon.fried@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Sarah Sharp <sarah.a.sharp@...ux.intel.com>,
	Daniel Borkmann <dborkman@...hat.com>,
	Alan Cox <alan@...ux.intel.com>,
	Wilfried Klaebe <w-lkml@...enslange-mailadresse.de>,
	Mostyn Bramley-Moore <mbmcode@...il.com>,
	Toby Smith <toby@...mith.id.au>,
	Archana kumari <archanakumari959@...il.com>,
	Jason Wang <jasowang@...hat.com>,
	Himangi Saraogi <himangi774@...il.com>,
	Iulia Manda <iulia.manda21@...il.com>,
	"open list:STAGING SUBSYSTEM" <devel@...verdev.osuosl.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: netlogic: fixed checkpatch.pl styling warnings

On Sun, Aug 31, 2014 at 03:16:48AM +0300, Ramon Fried wrote:
> This patch fixes the following checkpatch.pl warnings:
> 
> WARNING: Possible unnecessary 'out of memory' message
> #146: FILE: ./xlr_net.c:146:
> +       if (!skb) {
> +               pr_err("SKB allocation failed\n");
> 
> WARNING: Missing a blank line after declarations
> #1107: FILE: ./xlr_net.c:1107:
> +       struct xlr_net_priv *priv = platform_get_drvdata(pdev);
> +       unregister_netdev(priv->ndev);
> 
> Signed-off-by: Ramon Fried <ramon.fried@...il.com>

This is two different things, and as such, should be sent in 2 different
patches?

Also, you sent this to a lot of people, did they all really need it?

> ---
>  drivers/staging/netlogic/xlr_net.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c
> index 9bf407d..28a42831 100644
> --- a/drivers/staging/netlogic/xlr_net.c
> +++ b/drivers/staging/netlogic/xlr_net.c
> @@ -142,10 +142,8 @@ static inline struct sk_buff *xlr_alloc_skb(void)
>  
>  	/* skb->data is cache aligned */
>  	skb = alloc_skb(XLR_RX_BUF_SIZE, GFP_ATOMIC);
> -	if (!skb) {
> -		pr_err("SKB allocation failed\n");
> +	if (!skb)
>  		return NULL;
> -	}
>  	mac_put_skb_back_ptr(skb);
>  	return skb;
>  }
> @@ -1104,6 +1102,7 @@ err_gmac:
>  static int xlr_net_remove(struct platform_device *pdev)
>  {
>  	struct xlr_net_priv *priv = platform_get_drvdata(pdev);
> +
>  	unregister_netdev(priv->ndev);
>  	mdiobus_unregister(priv->mii_bus);
>  	mdiobus_free(priv->mii_bus);

Finally, this patch doesn't apply at all to my tree, so even if I wanted
to apply it, I couldn't.  Please refresh it against the staging-next
branch of the staging.git tree on git.kernel.org, and if it is still
relevant (hint, half of it isn't), then redo it and resend.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/