linux-kernel - Re: [PATCH] m68k/atari: Remove obsolete keyboard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5402E5D8.6080401@gmail.com>
Date:	Sun, 31 Aug 2014 21:07:36 +1200
From:	Michael Schmitz <schmitzmic@...il.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
CC:	linux-m68k@...ts.linux-m68k.org, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] m68k/atari: Remove obsolete keyboard_tasklet scheduling

Hi Geert
> If CONFIG_VT=n:
>
> arch/m68k/atari/built-in.o: In function `atari_keyboard_interrupt':
> atakeyb.c:(.text+0x1846): undefined reference to `keyboard_tasklet'
> atakeyb.c:(.text+0x1852): undefined reference to `keyboard_tasklet'
>   

Has keyboard_tasklet gone for good, or just been conditionalized on 
CONFIG_VT?

> I think the keyboard_tasklet scheduling is no longer needed, as I
> believe it's handled by drivers/tty/vt/keyboard.c based on events
> received from the input subsystem. So just remove it.
>   

I'd like to test this on real hardware (though ARAnyM does emulate the 
keyboard ACIA IIRC - if you had a working keyboard there I should find 
no different),

Cheers,

    Michael


> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
> Not tested on real hardware. ARAnyM doesn't have keyboard LEDs.
>
>  arch/m68k/atari/atakeyb.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/m68k/atari/atakeyb.c b/arch/m68k/atari/atakeyb.c
> index 95022b04b62d..1e2be1d34635 100644
> --- a/arch/m68k/atari/atakeyb.c
> +++ b/arch/m68k/atari/atakeyb.c
> @@ -170,7 +170,6 @@ repeat:
>  	if (acia_stat & ACIA_RDRF) {
>  		/* received a character */
>  		scancode = acia.key_data;	/* get it or reset the ACIA, I'll get it! */
> -		tasklet_schedule(&keyboard_tasklet);
>  	interpret_scancode:
>  		switch (kb_state.state) {
>  		case KEYBOARD:
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/