linux-kernel - Possible regression in 3.17-rc2 in i915 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 31 Aug 2014 15:57:52 +0200
From:	"Tibor Billes" <tbilles@....com>
To:	"Ville Syrjälä" 
	<ville.syrjala@...ux.intel.com>, "David Airlie" <airlied@...ux.ie>,
	"Daniel Vetter" <daniel.vetter@...ll.ch>,
	"Jani Nikula" <jani.nikula@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Possible regression in 3.17-rc2 in i915 driver

Hi!

I tried to upgrade my kernel from 3.16 to 3.17-rc2 and I found that my laptop
was unable to boot. The boot process hangs after 2-3 seconds (according to
timestamps of log messages). The last kernel log line I usually see is the
discovery of my touchpad: "input: SynPS/2 Synaptics TouchPad as
/devices/platform/i8042/serio2/input/input11".

I did a git bisect and it pointed me to the following commit:
commit 208bf9fdcd3575aa4a5d48b3e0295f7cdaf6fc44
Author: Ville Syrjälä <ville.syrjala@...ux.intel.com>
Date:   Mon Aug 11 13:15:35 2014 +0300

    drm/i915: Fix locking for intel_enable_pipe_a()

    intel_enable_pipe_a() gets called with all the modeset locks already
    held (by drm_modeset_lock_all()), so trying to grab the same
    locks using another drm_modeset_acquire_ctx is going to fail miserably.

    Move most of the drm_modeset_acquire_ctx handling (init/drop/fini)
    out from intel_{get,release}_load_detect_pipe() into the callers
    (intel_{crt,tv}_detect()). Only the actual locking and backoff
    handling is left in intel_get_load_detect_pipe(). And in
    intel_enable_pipe_a() we just share the mode_config.acquire_ctx from
    drm_modeset_lock_all() which is already holding all the relevant locks.

    It's perfectly legal to lock the same ww_mutex multiple times using the
    same ww_acquire_ctx. drm_modeset_lock() will convert the returned
    -EALREADY into 0, so the caller doesn't need to do antyhing special.

    Fixes a hang on resume on my 830.

    Signed-off-by: Ville Syrjälä <ville.syrjala@...ux.intel.com>
    Reviewed-by: Daniel Vetter <daniel.vetter@...ll.ch>
    Cc: stable@...r.kernel.org
    Signed-off-by: Jani Nikula <jani.nikula@...el.com>

I tried booting with the above commit reverted on top of 3.17-rc2 and it
booted successfully.

I also did a MagicSyrq-W (Display list of blocked (D state) tasks) after the
boot process stopped (using plain 3.17-rc2, without reverting the above commit)
and it showed that plymouthd was blocked with the following call trace (hand
copied):
irq_exit
common_interrupt
schedule_preemt_disabled
__mutex_lock_slowpath
mutex_lock
drm_modeset_lock
drm_getconnector
drm_mode_getcrttc
drm_ioctl
...

This may have something to do with the hang or it may not, I don't know but is
related to drm locking so I thought it was a good idea to mention it.

My laptop is an old Fujitsu-Siemens Amilo M1450g, running Linux Mint 16.

Let me know if I can help further debug this issue.

Tibor Billes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/