lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 1 Sep 2014 16:24:14 +0800 From: Shawn Guo <shawn.guo@...escale.com> To: Philippe Reynes <tremyfr@...il.com> CC: <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>, <kernel@...gutronix.de>, <shc_work@...l.ru> Subject: Re: [PATCH v3] apf27dev: add max1027 in the dts On Sun, Aug 31, 2014 at 10:40:29PM +0200, Philippe Reynes wrote: > > Signed-off-by: Philippe Reynes <tremyfr@...il.com> > --- > arch/arm/boot/dts/imx27-apf27dev.dts | 17 +++++++++++++++++ > 1 files changed, 17 insertions(+), 0 deletions(-) > > Changelog: > v3: (thanks Alexander Shiyan for the feedback) > - add datasheet pin name as comment > > v2: (thanks Alexander Shiyan for the feedback) > - spi mode 0 is the default so no need to explicitly define it > > diff --git a/arch/arm/boot/dts/imx27-apf27dev.dts b/arch/arm/boot/dts/imx27-apf27dev.dts > index b982309..0c08fbb 100644 > --- a/arch/arm/boot/dts/imx27-apf27dev.dts > +++ b/arch/arm/boot/dts/imx27-apf27dev.dts > @@ -82,6 +82,16 @@ > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_cspi1 &pinctrl_cspi1_cs>; > status = "okay"; > + > + adc@0 { > + compatible = "maxim,max1027"; > + reg = <0>; > + interrupt-parent = <&gpio5>; > + interrupts = <15 IRQ_TYPE_EDGE_FALLING>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_max1027>; > + spi-max-frequency = <10000000>; > + }; > }; > > &cspi2 { > @@ -230,6 +240,13 @@ > pinctrl_sdhc2_cd: sdhc2cdgrp { > fsl,pins = <MX27_PAD_TOUT__GPIO3_14 0x0>; > }; > + > + pinctrl_max1027: max1027 { The pinctrl entries are alphabetically sorted in there. Can you also do that for your addition? > + fsl,pins = < > + MX27_PAD_UART1_CTS__GPIO5_14 0 /* CNVST */ > + MX27_PAD_UART1_RTS__GPIO5_15 0 /* EOC */ Can you follow the convention to use hex value for the config cell, i.e. s/0/0x0? Shawn > + >; > + }; > }; > }; > > -- > 1.7.4.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists