linux-kernel - Re: [PATCH v2 2/3] iio: accel: BMC150: fix issues when CONFIG_PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140901092431.GA12606@lpalcu-linux>
Date:	Mon, 1 Sep 2014 12:24:32 +0300
From:	Laurentiu Palcu <laurentiu.palcu@...el.com>
To:	Jonathan Cameron <jic23@...nel.org>
Cc:	linux-iio@...r.kernel.org, srinivas.pandruvada@...ux.intel.com,
	knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] iio: accel: BMC150: fix issues when
 CONFIG_PM_RUNTIME is not set

On Sat, Aug 30, 2014 at 11:45:33AM +0100, Jonathan Cameron wrote:
> On 29/08/14 09:38, Laurentiu Palcu wrote:
> > When CONFIG_PM_RUNTIME is not set, the following issues are seen:
> >  * warning message at compilation time:
> >     warning: 'bmc150_accel_get_startup_times' defined but not used [-Wunused-function]
> >  * bmc150_accel_set_power_state() will always fail and reading the
> >    accelerometer data is impossible;
> Why? Would be good to have an explanation here...
> 
> If on is true then it will call pm_runtime_get_sync which calls __pm_runtime_resume
> which when CONFIG_PM_RUNTIME is not defined returns 1 which is not an error.
> 
> In the on = false case it calls pm_runtime_put_autosuspend which calls __pm_runtime_suspend
> which returns -ENOSYS and gives our error.
> 
> I'll add something to the patch description to this effect.
Thank you! I'll try to better describe my changes next time.

laurentiu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/