lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 1 Sep 2014 12:01:19 +0100 From: Mark Rutland <mark.rutland@....com> To: Andrew Bresticker <abrestic@...omium.org> Cc: Ralf Baechle <ralf@...ux-mips.org>, Rob Herring <robh+dt@...nel.org>, Pawel Moll <Pawel.Moll@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, Jeffrey Deans <jeffrey.deans@...tec.com>, Markos Chandras <markos.chandras@...tec.com>, Paul Burton <paul.burton@...tec.com>, Thomas Gleixner <tglx@...utronix.de>, Jason Cooper <jason@...edaemon.net>, "linux-mips@...ux-mips.org" <linux-mips@...ux-mips.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 03/12] of: Add binding document for MIPS GIC On Fri, Aug 29, 2014 at 11:14:30PM +0100, Andrew Bresticker wrote: > The Global Interrupt Controller (GIC) present on certain MIPS systems > can be used to route external interrupts to individual VPEs and CPU > interrupt vectors. It also supports a timer and software-generated > interrupts. > > Signed-off-by: Andrew Bresticker <abrestic@...omium.org> > --- > Documentation/devicetree/bindings/mips/gic.txt | 50 ++++++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mips/gic.txt > > diff --git a/Documentation/devicetree/bindings/mips/gic.txt b/Documentation/devicetree/bindings/mips/gic.txt > new file mode 100644 > index 0000000..725f1ef > --- /dev/null > +++ b/Documentation/devicetree/bindings/mips/gic.txt > @@ -0,0 +1,50 @@ > +MIPS Global Interrupt Controller (GIC) > + > +The MIPS GIC routes external interrupts to individual VPEs and IRQ pins. > +It also supports a timer and software-generated interrupts which can be > +used as IPIs. > + > +Required properties: > +- compatible : Should be "mti,global-interrupt-controller" I couldn't find "mti" in vendor-prefixes.txt (as of v3.17-rc3). If there's not a patch to add it elsewhere, would you mind providing one with this series? > +- reg : Base address and length of the GIC registers. > +- interrupts : Core interrupts to which the GIC may route external interrupts. How many? in any order? > +- interrupt-controller : Identifies the node as an interrupt controller > +- #interrupt-cells : Specifies the number of cells needed to encode an > + interrupt specifier. Should be 3. > + - The first cell is the GIC interrupt number. > + - The second cell encodes the interrupt flags. > + See <include/dt-bindings/interrupt-controller/irq.h> for a list of valid > + flags. Are all the flags valid for this interrupt controller? > + - The optional third cell indicates which CPU interrupt vector the GIC > + interrupt should be routed to. It is a 0-based index into the list of > + GIC-to-CPU interrupts specified in the "interrupts" property described > + above. For example, a '2' in this cell will route the interrupt to the > + 3rd core interrupt listed in 'interrupts'. If omitted, the interrupt will > + be routed to the 1st core interrupt. I don't follow why this should be in the DT. Why is this necessary? I also don't follow how this can be ommitted, given interrupt-cells is required to be three by the wording above. > + > +Example: > + > + cpu_intc: interrupt-controller@0 { Nit: there's no reg on this node, so there shouldn't be a unit-address. Thanks, Mark. > + compatible = "mti,cpu-interrupt-controller"; > + > + interrupt-controller; > + #interrupt-cells = <1>; > + }; > + > + gic: interrupt-controller@...c0000 { > + compatible = "mti,global-interrupt-controller"; > + reg = <0x1bdc0000 0x20000>; > + > + interrupt-controller; > + #interrupt-cells = <3>; > + > + interrupt-parent = <&cpu_intc>; > + interrupts = <3>, <4>; > + }; > + > + uart@...01400 { > + ... > + interrupt-parent = <&gic>; > + interrupts = <24 IRQ_TYPE_LEVEL_HIGH 0>; > + ... > + }; > -- > 2.1.0.rc2.206.gedb03e5 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists