linux-kernel - Re: [PATCH v2] usb: gadget: net2280: Fix invalid handling of Reset irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 1 Sep 2014 13:25:31 +0200
From:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
To:	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Linux USB Mailing List <linux-usb@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Cc:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
Subject: Re: [PATCH v2] usb: gadget: net2280: Fix invalid handling of Reset irq

Hello Felipe

I think that you have forgotten about this patch :). It is needed by
usb3380 in usb3.0 mode. Otherwise the device keeps reseting.

Thanks!

On Tue, Aug 26, 2014 at 6:00 PM, Ricardo Ribalda Delgado
<ricardo.ribalda@...il.com> wrote:
> Without this patch, some hosts keep restarting indefinitely the target.
>
> Fixes: ae8e530 (usb: gadget: net2280: Code Cleanup)
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
> ---
>
> v2: Request by Felipe Balbi
>
> Use Fixes: on commit message
>
>  drivers/usb/gadget/udc/net2280.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c
> index f4eac11..2e95715 100644
> --- a/drivers/usb/gadget/udc/net2280.c
> +++ b/drivers/usb/gadget/udc/net2280.c
> @@ -3320,7 +3320,7 @@ static void handle_stat1_irqs(struct net2280 *dev, u32 stat)
>         if (stat & tmp) {
>                 writel(tmp, &dev->regs->irqstat1);
>                 if ((((stat & BIT(ROOT_PORT_RESET_INTERRUPT)) &&
> -                               (readl(&dev->usb->usbstat) & mask)) ||
> +                               ((readl(&dev->usb->usbstat) & mask) == 0)) ||
>                                 ((readl(&dev->usb->usbctl) &
>                                         BIT(VBUS_PIN)) == 0)) &&
>                                 (dev->gadget.speed != USB_SPEED_UNKNOWN)) {
> --
> 2.1.0
>



-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/