linux-kernel - Re: [PATCH] semaphore: Resolve some shadow warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140901120244.GI27892@worktop.ger.corp.intel.com>
Date:	Mon, 1 Sep 2014 14:02:44 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	mingo@...hat.com, Mark Rustad <mark.d.rustad@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] semaphore: Resolve some shadow warnings

On Thu, Aug 28, 2014 at 05:19:26AM -0700, Jeff Kirsher wrote:
> From: Mark Rustad <mark.d.rustad@...el.com>
> 
> Resolve some shadow warnings resulting from using the name
> jiffies, which is a well-known global. This is not a problem
> of course, but it could be a trap for someone copying and
> pasting code, and it just makes W=2 a little cleaner.
> 
> Signed-off-by: Mark Rustad <mark.d.rustad@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Why isn't Mark sending this email?

> ---
>  kernel/locking/semaphore.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/kernel/locking/semaphore.c b/kernel/locking/semaphore.c
> index 6815171..7782dbc 100644
> --- a/kernel/locking/semaphore.c
> +++ b/kernel/locking/semaphore.c
> @@ -36,7 +36,7 @@
>  static noinline void __down(struct semaphore *sem);
>  static noinline int __down_interruptible(struct semaphore *sem);
>  static noinline int __down_killable(struct semaphore *sem);
> -static noinline int __down_timeout(struct semaphore *sem, long jiffies);
> +static noinline int __down_timeout(struct semaphore *sem, long njiffies);
>  static noinline void __up(struct semaphore *sem);

So what's wrong with calling it "timeout" instead? That's what most
other sites do.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/