linux-kernel - Re: [PATCH] arch/microblaze/include/asm/entry.h: Include "linux/linkage.h" to avoid compiling issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54047BC8.4010308@monstr.eu>
Date:	Mon, 01 Sep 2014 15:59:36 +0200
From:	Michal Simek <monstr@...str.eu>
To:	Chen Gang <gang.chen.5i5j@...il.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arch/microblaze/include/asm/entry.h: Include "linux/linkage.h"
 to avoid compiling issue

On 08/06/2014 03:32 PM, Chen Gang wrote:
> "entry.h" needs 'asmlinkage', and "asm/linkage.h" does not provide it.
> So need include "linux/linkage.h" to use generic one instead of.
> 
> The related error (with allmodconfig under microblaze):
> 
>     CC [M]  drivers/net/ethernet/emulex/benet/be_main.o
>   In file included from ./arch/microblaze/include/asm/processor.h:17:0,
>                    from include/linux/prefetch.h:14,
>                    from drivers/net/ethernet/emulex/benet/be_main.c:18:
>   ./arch/microblaze/include/asm/entry.h:33:19: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'void'
>    extern asmlinkage void do_notify_resume(struct pt_regs *regs, int in_syscall);
>                      ^
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com>
> ---
>  arch/microblaze/include/asm/entry.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/microblaze/include/asm/entry.h b/arch/microblaze/include/asm/entry.h
> index b4a4cb1..596e485 100644
> --- a/arch/microblaze/include/asm/entry.h
> +++ b/arch/microblaze/include/asm/entry.h
> @@ -15,6 +15,7 @@
>  
>  #include <asm/percpu.h>
>  #include <asm/ptrace.h>
> +#include <linux/linkage.h>
>  
>  /*
>   * These are per-cpu variables required in entry.S, among other
> 

Applied.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)