linux-kernel - Re: [PATCH] xhci-ring: Fix Null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1409011013100.7410-100000@netrider.rowland.org>
Date:	Mon, 1 Sep 2014 10:16:38 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Mathias Nyman <mathias.nyman@...el.com>
cc:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Linux USB Mailing List <linux-usb@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] xhci-ring: Fix Null pointer dereference

On Mon, 1 Sep 2014, Mathias Nyman wrote:

> On 09/01/2014 12:36 PM, Ricardo Ribalda Delgado wrote:
> > After some time of use (one hour or so) my system started to behave
> > "weird". I did check  dmesg and I was receiving the following line
> > again and again:
> > 
> > usb-storage: Error in queuecommand_lck: us->sfb= ffff8805bd61ccc0

This is probably caused by some transfer not occurring correctly.  With 
a usbmon trace we could see what was going on.

> > I did disconnect the usb device and the whole computer crashed :S
> > 
> 
> Ok, thanks.
> 
> Would you say things work better after the patch?
> 
> I still think the patch solves part of the issue, i.e. how we handle halted endpoints
> in reset, but I don't know the reason why the endpoints stall in the first place

The endpoint stall occurs because the device's protocol requires the
endpoint to stall.  The reason doesn't matter; xhci-hcd should handle 
stalls correctly whenever they occur.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/