| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <540484FB.1060906@codethink.co.uk> Date: Mon, 01 Sep 2014 15:38:51 +0100 From: Rob Jones <rob.jones@...ethink.co.uk> To: Alexey Dobriyan <adobriyan@...il.com> CC: Linux Kernel <linux-kernel@...r.kernel.org>, Andrew Morton <akpm@...ux-foundation.org> Subject: Re: [PATCH] fs: replace int param with size_t for seq_open_private() On 01/09/14 15:13, Alexey Dobriyan wrote: > On Mon, Sep 1, 2014 at 4:54 PM, Rob Jones <rob.jones@...ethink.co.uk> wrote: >> >> >> On 01/09/14 14:43, Alexey Dobriyan wrote: >>>> >>>> void *__seq_open_private(struct file *f, const struct seq_operations >>>> *ops, >>>> - int psize) >>>> + size_t psize) >>> >>> >>> It should be "unsigned int" at most. >>> As almost all in-kernel lengths. > >> I don't agree. Ultimately this parameter ends up as a parameter to >> kmalloc where it is expected to be a size_t. > > Which is a mistake too because allocations are never that large. Yet. > > Save REX prefix, keep length unsigned int! I am happy to do this if the general opinion is that it is the right thing but I would like more input first. Using size_t was suggested by Andrew Morton which sounds to me like a heavy gun on the side of size_t. > > Alexey > > -- Rob Jones Codethink Ltd mailto:rob.jones@...ethink.co.uk tel:+44 161 236 5575 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists