lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 01 Sep 2014 09:26:19 -0700
From:	Joe Perches <>
To:	sunwxg <>
Cc:	Greg Kroah-Hartman <>,
	Dulshani Gunawardhana <>,
	Josh Triplett <>,
	"John L. Hammond" <>,
	Andreas Dilger <>,
	Chi Pham <>,
	Oleg Drokin <>,,
Subject: Re: [PATCH] staging: lustre: lov_pack: fix coding style issue

On Mon, 2014-09-01 at 23:52 +0800, sunwxg wrote:
> Fix the style error checking by
> ERROR: space required after that ','
> diff --git a/drivers/staging/lustre/lustre/lov/lov_pack.c b/drivers/staging/lustre/lustre/lov/lov_pack.c
> @@ -95,7 +95,7 @@ void lov_dump_lmm_v1(int level, struct lov_mds_md_v1 *lmm)
>  void lov_dump_lmm_v3(int level, struct lov_mds_md_v3 *lmm)
>  {
>  	lov_dump_lmm_common(level, lmm);
> -	CDEBUG(level,"pool_name "LOV_POOLNAMEF"\n", lmm->lmm_pool_name);
> +	CDEBUG(level, "pool_name "LOV_POOLNAMEF"\n", lmm->lmm_pool_name);

I think it better to separate the pre-coalesced
bits of the string like:

	"pool name " LOV_POOLNAMEF "\n",

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists