lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 01 Sep 2014 09:26:19 -0700
From:	Joe Perches <joe@...ches.com>
To:	sunwxg <sun.wxg@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Dulshani Gunawardhana <dulshani.gunawardhana89@...il.com>,
	Josh Triplett <josh@...htriplett.org>,
	"John L. Hammond" <john.hammond@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	Chi Pham <fempsci@...il.com>,
	Oleg Drokin <green@...uxhacker.ru>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: lustre: lov_pack: fix coding style issue

On Mon, 2014-09-01 at 23:52 +0800, sunwxg wrote:
> Fix the style error checking by checkpatch.pl
> ERROR: space required after that ','
[]
> diff --git a/drivers/staging/lustre/lustre/lov/lov_pack.c b/drivers/staging/lustre/lustre/lov/lov_pack.c
[]
> @@ -95,7 +95,7 @@ void lov_dump_lmm_v1(int level, struct lov_mds_md_v1 *lmm)
>  void lov_dump_lmm_v3(int level, struct lov_mds_md_v3 *lmm)
>  {
>  	lov_dump_lmm_common(level, lmm);
> -	CDEBUG(level,"pool_name "LOV_POOLNAMEF"\n", lmm->lmm_pool_name);
> +	CDEBUG(level, "pool_name "LOV_POOLNAMEF"\n", lmm->lmm_pool_name);

I think it better to separate the pre-coalesced
bits of the string like:

	"pool name " LOV_POOLNAMEF "\n",


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists