linux-kernel - Re: [PATCH v2] drm/i915: Fix lock dropping in intel_tv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <trinity-c4c16d70-6e35-4a53-b0ce-663da28bc5ef-1409602778203@3capp-mailcom-bs16>
Date:	Mon, 1 Sep 2014 22:19:38 +0200
From:	"Tibor Billes" <tbilles@....com>
To:	ville.syrjala@...ux.intel.com
Cc:	intel-gfx@...ts.freedesktop.org, "David Airlie" <airlied@...ux.ie>,
	"Daniel Vetter" <daniel.vetter@...ll.ch>,
	"Jani Nikula" <jani.nikula@...ux.intel.com>,
	linux-kernel@...r.kernel.org,
	"Chris Wilson" <chris@...is-wilson.co.uk>
Subject: Re: [PATCH v2] drm/i915: Fix lock dropping in intel_tv_detect()

Hi!

From: ville.syrjala@...ux.intel.com Sent: Monday, September 01, 2014 at 12:07 PM

> When intel_tv_detect() fails to do load detection it would forget to
> drop the locks and clean up the acquire context. Fix it up.
> 
> This is a regression from:
> commit 208bf9fdcd3575aa4a5d48b3e0295f7cdaf6fc44
> Author: Ville Syrjälä <ville.syrjala@...ux.intel.com>
> Date: Mon Aug 11 13:15:35 2014 +0300
> 
> drm/i915: Fix locking for intel_enable_pipe_a()
> 
> v2: Make the code more readable (Chris)
> 
> Cc: Tibor Billes <tbilles@....com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@...ux.intel.com>

I tested the posted patch, applying it on top of 3.17-rc2 did solve my boot problems. Just to make sure I also tried a clean 3.17-rc3, which was unable to boot. With this patch applied, it again booted successfully.

I'm not quite sure how tags work, but you may add my following tags:
Reported-by: Tibor Billes <tbilles@....com>
Tested-by: Tibor Billes <tbilles@....com>

Thank you all for the quick responses and the patch, nice work! :)

Tibor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/