linux-kernel - Re: [PATCH] Drivers:firewire: fix style errors in core-card.c This is a patch in the core-card.c file which fixes up 2 warnings found by the checkpatch.pl tool Signed-off-by: Sander Nemvalts <snemvalts@...il.com>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140901235605.5466b6a6@kant>
Date:	Mon, 1 Sep 2014 23:56:05 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Sander Nemvalts <snemvalts@...il.com>
Cc:	linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Drivers:firewire: fix style errors in core-card.c This
 is a patch in the core-card.c file which fixes up 2 warnings found by the
 checkpatch.pl tool Signed-off-by: Sander Nemvalts <snemvalts@...il.com>

On Sep 01 Sander Nemvalts wrote:
> --- a/drivers/firewire/core-card.c
> +++ b/drivers/firewire/core-card.c
> @@ -89,7 +89,8 @@ static size_t config_rom_length = 1 + 4 + 1 + 1;
>  #define BIB_ISC			((1) << 29)
>  #define BIB_CMC			((1) << 30)
>  #define BIB_IRMC		((1) << 31)
> -#define NODE_CAPABILITIES	0x0c0083c0 /* per IEEE 1394 clause 8.3.2.6.5.2 */
> +/* per IEEE 1394 clause 8.3.2.6.5.2 */
> +#define NODE_CAPABILITIES	0x0c0083c0

This is no improvement.

>  /*
>   * IEEE-1394 specifies a default SPLIT_TIMEOUT value of 800 cycles (100 ms),
> @@ -132,7 +133,7 @@ static void generate_config_rom(struct fw_card *card, __be32 *config_rom)
>  	j = 7 + descriptor_count;
>  
>  	/* Generate root directory entries for descriptors. */
> -	list_for_each_entry (desc, &descriptor_list, link) {
> +	list_for_each_entry(desc, &descriptor_list, link) {
>  		if (desc->immediate > 0)
>  			config_rom[i++] = cpu_to_be32(desc->immediate);
>  		config_rom[i] = cpu_to_be32(desc->key | (j - i));

We are writing
	for (a; b; c);
not
	for(a; b; c);
and thus a space after list_for_each and friends makes sense.
-- 
Stefan Richter
-=====-====- =--= ----=
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/