linux-kernel - Re: [PATCH] powercap/rapl: lower warning level for domain detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2181254.mWuCKKqmQW@vostro.rjw.lan>
Date:	Tue, 02 Sep 2014 01:48:40 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Jacob Pan <jacob.jun.pan@...ux.intel.com>
Cc:	Rafael Wysocki <rafael.j.wysocki@...el.com>,
	Linux PM <linux-pm@...r.kernel.org>,
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] powercap/rapl: lower warning level for domain detection

On Thursday, August 28, 2014 09:56:08 PM Jacob Pan wrote:
> Many CPUs do not support complete set of RAPL domains, as a
> result this detection failed message is very misleading and
> annoying. So lower the warning message to info and reword.
> 
> Signed-off-by: Jacob Pan <jacob.jun.pan@...ux.intel.com>

What about printing a (info-level) message if the RAPL domain *is*
supported?  That surely is more interesting?

> ---
>  drivers/powercap/intel_rapl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
> index b1cda6f..0b282e7 100644
> --- a/drivers/powercap/intel_rapl.c
> +++ b/drivers/powercap/intel_rapl.c
> @@ -1169,7 +1169,7 @@ static int rapl_detect_domains(struct rapl_package *rp, int cpu)
>  		if (!rapl_check_domain(cpu, i))
>  			rp->domain_map |= 1 << i;
>  		else
> -			pr_warn("RAPL domain %s detection failed\n",
> +			pr_info("RAPL domain %s not supported\n",
>  				rapl_domain_names[i]);
>  	}
>  	rp->nr_domains = bitmap_weight(&rp->domain_map,	RAPL_DOMAIN_MAX);
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/