linux-kernel - Re: [PATCH 01/12] Staging: rtl8821ae: hal_bt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140902091939.GB6600@mwanda>
Date:	Tue, 2 Sep 2014 12:19:40 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	An Ha <zero579911@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/12] Staging: rtl8821ae: hal_bt_coexist: fix commenting
 style

Hm...  Now you've broken it into *too* many separate patches.  Also the
subjects are the same.  Also the subjects are too vague.  Which coding
style issue is addressed?

It should be something like:
patch 1: comments
patch 2: add/remove spaces
patch 3: fix quoted text
patch 4: braces
patch 5: add a blank line

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/