linux-kernel - Re: [PATCH v2] i2c: mv64xxx: continue probe when clock-frequency is missing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140902103959.GC1266@katana>
Date:	Tue, 2 Sep 2014 12:39:59 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Chen-Yu Tsai <wens@...e.org>
Cc:	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Gregory CLEMENT <gregory.clement@...e-electrons.com>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, Andrew Lunn <andrew@...n.ch>,
	linux-sunxi@...glegroups.com, stable@...r.kernel.org
Subject: Re: [PATCH v2] i2c: mv64xxx: continue probe when clock-frequency is
 missing

On Mon, Sep 01, 2014 at 10:28:13PM +0800, Chen-Yu Tsai wrote:
> The "clock-frequency" DT property is listed as optional, However,
> the current code stores the return value of of_property_read_u32 in
> the return code of mv64xxx_of_config, but then forgets to clear it
> after setting the default value of "clock-frequency". It is then
> passed out to the main probe function, resulting in a probe failure
> when "clock-frequency" is missing.
> 
> This patch checks and then throws away the return value of
> of_property_read_u32, instead of storing it and having to clear it
> afterwards.
> 
> This issue was discovered after the property was removed from all
> sunxi DTs.

Hmm, I don't like that removal. Probably I should take care that this
property is not "optional" but "recommended". The default value is
depending on the driver, mostly because of historic reasons. It is
definately better to explicitly state it. Despite all that...

> 
> Fixes: 4c730a06c19bb ("i2c: mv64xxx: Set bus frequency to 100kHz if clock-frequency is not provided")
> Signed-off-by: Chen-Yu Tsai <wens@...e.org>
> Cc: stable@...r.kernel.org
> Acked-by: Andrew Lunn <andrew@...n.ch>
> Acked-by: Maxime Ripard <maxime.ripard@...e-electrons.com>

Applied to for-current, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)