| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140902004034.5251.35559@quantum>
Date: Mon, 01 Sep 2014 17:40:34 -0700
From: Mike Turquette <mturquette@...aro.org>
To: Tuomas Tynkkynen <ttynkkynen@...dia.com>,
linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-pm@...r.kernel.org
Cc: "Stephen Warren" <swarren@...dotorg.org>,
"Thierry Reding" <thierry.reding@...il.com>,
"Peter De Schrijver" <pdeschrijver@...dia.com>,
"Prashant Gaikwad" <pgaikwad@...dia.com>,
"Rafael J. Wysocki" <rjw@...ysocki.net>,
"Viresh Kumar" <viresh.kumar@...aro.org>,
"Paul Walmsley" <pwalmsley@...dia.com>,
"Vince Hsu" <vinceh@...dia.com>, devicetree@...r.kernel.org,
"Tuomas Tynkkynen" <ttynkkynen@...dia.com>
Subject: Re: [PATCH v4 00/16] Tegra124 CL-DVFS / DFLL clocksource, plus cpufreq
Quoting Tuomas Tynkkynen (2014-08-20 14:04:28)
> v4 changes:
> DFLL:
> - fix wrong register accessors used for the DFLL_OUTPUT_CFG register
> - I decided to leave the dfll_i2c_{readl,writel} separate since the
> correct barrier function still needs to be called
> - fix PMIC I2C voltage register address being uninitialized
> cpufreq:
> - back to 'depends on GENERIC_CPUFREQ_CPU0' from 'select GENERIC_CPUFREQ_CPU0'
> - leads to new patch to update the defconfigs
> - check for get_cpu_device() return value
> - add comment why an extra platform driver+device is required
>
> v3 changes:
> - Fix incorrect order of arguments to dfll_scale_dvco_rate
> - Fix accidental commas at end-of-statement to semicolons
> - Some cpufreq changes:
> - rename cpufreq-tegra to cpufreq-tegra20
> - have separate Kconfig entries for Tegra20/Tegra124 support
> - use 'select GENERIC_CPUFREQ_CPU0', not depends
> - support unbinding of the platform device
> - requires adding the vdd_cpu regulator to the DT so
> the old voltage can be restored when switching to PLLX
> - allocate a state structure instead of globals
> - use of_match_machine()
> - various style nits fixed
>
> The cpufreq part is dependant on the of_match_machine() series.
>
> Original cover letter:
>
> This series implements the DFLL/CL-DVFS clock source for the fast CPU
> cluster on Tegra124, and a cpufreq driver that uses the DFLL for
> clocking the CPU. Most of this is based on Paul Walmsley's public patch
> set from December 2013, which is available at
> http://comments.gmane.org/gmane.linux.ports.tegra/15273
>
> The DFLL clock hardware is a voltage-controlled oscillator plus
> control logic that compares the generated output clock with a
> 51 MHz reference clock, and can make decisions to either lower
> or raise the DFLL voltage to keep the output rate close to the
> software-requested rate. The voltage changes are done by
> communicating with an off-chip PMIC via either I2C or PWM.
> As the DFLL oscillator is powered via the CPU rail, using
> the DFLL as the CPU clocksource also gives us dynamic CPU
> voltage scaling.
>
> This series has been tested on the Jetson TK1 (Rev C). Porting this to
> the Venice2 should be simple, though do note that it does not have
> active cooling.
At a quick glance, the clock driver changes look good to me.
Regards,
Mike
>
> Thanks,
> Tuomas
>
> Paul Walmsley (1):
> clk: tegra: Add DFLL DVCO reset control for Tegra124
>
> Tuomas Tynkkynen (15):
> clk: tegra: Add binding for the Tegra124 DFLL clocksource
> clk: tegra: Add library for the DFLL clock source (open-loop mode)
> clk: tegra: Add closed loop support for the DFLL
> clk: tegra: Add functions for parsing CVB tables
> clk: tegra: Add Tegra124 DFLL clocksource platform driver
> clk: tegra: Save/restore CCLKG_BURST_POLICY on suspend
> clk: tegra: Add the DFLL as a possible parent of the cclk_g clock
> ARM: tegra: Add the DFLL to Tegra124 device tree
> ARM: tegra: Enable the DFLL on the Jetson TK1
> cpufreq: tegra124: Add device tree bindings
> cpufreq: tegra: Rename tegra-cpufreq to tegra20-cpufreq
> cpufreq: Add cpufreq driver for Tegra124
> ARM: tegra: Add entries for cpufreq on Tegra124
> ARM: tegra: Add CPU regulator to the Jetson TK1 device tree
> ARM: tegra: enable Tegra124 cpufreq driver by default
>
> .../bindings/clock/nvidia,tegra124-dfll.txt | 69 +
> .../bindings/cpufreq/tegra124-cpufreq.txt | 44 +
> arch/arm/boot/dts/tegra124-jetson-tk1.dts | 12 +-
> arch/arm/boot/dts/tegra124.dtsi | 33 +-
> arch/arm/configs/tegra_defconfig | 1 +
> arch/arm/mach-tegra/Kconfig | 1 +
> drivers/clk/tegra/Makefile | 3 +
> drivers/clk/tegra/clk-dfll.c | 1741 ++++++++++++++++++++
> drivers/clk/tegra/clk-dfll.h | 55 +
> drivers/clk/tegra/clk-tegra-super-gen4.c | 4 +-
> drivers/clk/tegra/clk-tegra124-dfll-fcpu.c | 165 ++
> drivers/clk/tegra/clk-tegra124.c | 61 +
> drivers/clk/tegra/clk.h | 3 +
> drivers/clk/tegra/cvb.c | 133 ++
> drivers/clk/tegra/cvb.h | 67 +
> drivers/cpufreq/Kconfig.arm | 13 +-
> drivers/cpufreq/Makefile | 3 +-
> drivers/cpufreq/tegra124-cpufreq.c | 215 +++
> .../cpufreq/{tegra-cpufreq.c => tegra20-cpufreq.c} | 0
> 19 files changed, 2616 insertions(+), 7 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/clock/nvidia,tegra124-dfll.txt
> create mode 100644 Documentation/devicetree/bindings/cpufreq/tegra124-cpufreq.txt
> create mode 100644 drivers/clk/tegra/clk-dfll.c
> create mode 100644 drivers/clk/tegra/clk-dfll.h
> create mode 100644 drivers/clk/tegra/clk-tegra124-dfll-fcpu.c
> create mode 100644 drivers/clk/tegra/cvb.c
> create mode 100644 drivers/clk/tegra/cvb.h
> create mode 100644 drivers/cpufreq/tegra124-cpufreq.c
> rename drivers/cpufreq/{tegra-cpufreq.c => tegra20-cpufreq.c} (100%)
>
> --
> 1.8.1.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists