linux-kernel - Re: [PATCH] usb: gadget: f_fs: add usb_functionfs_descs_head

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <xa1twq9mry13.fsf@mina86.com>
Date:	Tue, 02 Sep 2014 14:45:44 +0200
From:	Michal Nazarewicz <mina86@...a86.com>
To:	Zhuang Jin Can <jin.can.zhuang@...el.com>, balbi@...com,
	mgautam@...eaurora.org, andrzej.p@...sung.com
Cc:	jin.can.zhuang@...el.com, linux-api@...r.kernel.org,
	linux-kernel@...r.kernel.org, david.a.cohen@...el.com,
	hang.yuan@...el.com
Subject: Re: [PATCH] usb: gadget: f_fs: add usb_functionfs_descs_head_v2

On Tue, Sep 02 2014, Zhuang Jin Can <jin.can.zhuang@...el.com> wrote:
> Add usb_functionfs_descs_head_v2 structure for the new layout of
> descriptors.

NAK.  It's a duplicate of <https://lkml.org/lkml/2014/6/6/128> and even
more importantly, the format of the header is not fixed past the flags
field (e.g. fs_count may be missing), so fs_count, hs_count and ss_count
cannot be in the structure.

> Signed-off-by: Zhuang Jin Can <jin.can.zhuang@...el.com>
> ---
>  include/uapi/linux/usb/functionfs.h |    9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/include/uapi/linux/usb/functionfs.h b/include/uapi/linux/usb/functionfs.h
> index 0154b28..0b3f9fc 100644
> --- a/include/uapi/linux/usb/functionfs.h
> +++ b/include/uapi/linux/usb/functionfs.h
> @@ -32,6 +32,15 @@ struct usb_endpoint_descriptor_no_audio {
>  	__u8  bInterval;
>  } __attribute__((packed));
>  
> +struct usb_functionfs_descs_head_v2 {
> +	__le32 magic;
> +	__le32 length;
> +	__le32 flags;
> +	__le32 fs_count;
> +	__le32 hs_count;
> +	__le32 ss_count;
> +} __attribute__((packed));
> +
>  /* Legacy format, deprecated as of 3.14. */
>  struct usb_functionfs_descs_head {
>  	__le32 magic;

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +--<mpn@...gle.com>--<xmpp:mina86@...ber.org>--ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/