linux-kernel - Re: [PATCH] kernel/signal.c: whitespace fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 02 Sep 2014 14:48:03 +0200
From:	Richard Weinberger <richard@....at>
To:	Vishnu Pratap Singh <vishnu.ps@...sung.com>,
	akpm@...ux-foundation.org, oleg@...hat.com,
	paulmck@...ux.vnet.ibm.com, jkosina@...e.cz, fabf@...net.be,
	viro@...iv.linux.org.uk, linux-kernel@...r.kernel.org,
	cpgs@...sung.com
CC:	pintu.k@...sung.com, vishu13285@...il.com
Subject: Re: [PATCH] kernel/signal.c: whitespace fixes

Hi!

Am 02.09.2014 14:40, schrieb Vishnu Pratap Singh:
> From: "vishnu.ps" <vishnu.ps@...sung.com>
> 
> Fix minor errors and warning messages in kernel/signal.c.  These errors were
> reported by checkpatch while working with some modifications in signal.c
> file.
> 
> ERROR: code indent should use tabs where possible - 18
> ERROR: need consistent spacing around '&' (ctx:WxO) - 11
> ERROR: space prohibited after that '~' (ctx:OxW) - 11
> ERROR: trailing whitespace - 4
> ERROR: space required after that ',' (ctx:VxV) - 4
> ERROR: trailing statements should be on next line - 3
> ERROR: "foo * bar" should be "foo *bar" - 1
> 
> total 52 errors fixed.

Please don't run checkpatch.pl on in-kernel files.
The tool is designed to check patches, not files.
Such whitespace cleanups pollute the kernel history, i.e. such that
git blame returns false positives.

The purpose of --file is:
- Checking out-of-tree files (like existing drivers to be imported)
- One notable exception is drivers/staging/, you can run it on these files.

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/