| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140902125220.9247.32762.stgit@warthog.procyon.org.uk> Date: Tue, 02 Sep 2014 13:52:20 +0100 From: David Howells <dhowells@...hat.com> To: jmorris@...ei.org Cc: Andreea-Cristina Bernat <bernat.ada@...il.com>, keyrings@...ux-nfs.org, shemming@...cade.com, linux-kernel@...r.kernel.org, dhowells@...hat.com, linux-security-module@...r.kernel.org, paulmck@...ux.vnet.ibm.com Subject: [PATCH 4/5] KEYS: Fix use-after-free in assoc_array_gc() An edit script should be considered inaccessible by a function once it has called assoc_array_apply_edit() or assoc_array_cancel_edit(). However, assoc_array_gc() is accessing the edit script just after the gc_complete: label. Reported-by: Andreea-Cristina Bernat <bernat.ada@...il.com> Signed-off-by: David Howells <dhowells@...hat.com> Reviewed-by: Andreea-Cristina Bernat <bernat.ada@...il.com> cc: shemming@...cade.com cc: paulmck@...ux.vnet.ibm.com --- lib/assoc_array.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/assoc_array.c b/lib/assoc_array.c index c0b1007011e1..ae146f0734eb 100644 --- a/lib/assoc_array.c +++ b/lib/assoc_array.c @@ -1735,7 +1735,7 @@ ascend_old_tree: gc_complete: edit->set[0].to = new_root; assoc_array_apply_edit(edit); - edit->array->nr_leaves_on_tree = nr_leaves_on_tree; + array->nr_leaves_on_tree = nr_leaves_on_tree; return 0; enomem: -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists