linux-kernel - Re: [PATCH] sh: Fix build error caused by missing dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdXbKqcm1H3F6ML++XSjkWQzOSbzMQnb5aVwe8W2ohr0fw@mail.gmail.com>
Date:	Tue, 2 Sep 2014 18:02:40 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Pranith Kumar <bobby.prani@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Vivek Goyal <vgoyal@...hat.com>,
	Magnus Damm <damm@...nsource.se>,
	Simon Horman <horms+renesas@...ge.net.au>,
	Mark Salter <msalter@...hat.com>,
	Kees Cook <keescook@...omium.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	AKASHI Takahiro <takahiro.akashi@...aro.org>,
	"Steven Rostedt (Red Hat)" <rostedt@...dmis.org>,
	Robert Graffham <psquid@...uid.net>,
	Paul Bolle <pebolle@...cali.nl>,
	"open list:SUPERH" <linux-sh@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sh: Fix build error caused by missing dependencies

Hi Pranith,

On Tue, Sep 2, 2014 at 4:39 PM, Pranith Kumar <bobby.prani@...il.com> wrote:
> Fix a sh4-randconfig build failure which has the following splat:
>
> arch/sh/mm/cache-sh4.c:99:17: error: 'cached_to_uncached' undeclared (first use in this function)
> arch/sh/mm/cache-sh4.c:192:2: error: implicit declaration of function 'cpu_context' [-Werror=implicit-function-declaration]
>
> These errors are caused by missing dependencies on UNCACHED_MAPPING and MMU.
>
> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Signed-off-by: Pranith Kumar <bobby.prani@...il.com>
> ---
>  arch/sh/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
> index 244fb4c..619d5eb 100644
> --- a/arch/sh/Kconfig
> +++ b/arch/sh/Kconfig
> @@ -194,6 +194,8 @@ config CPU_SH4
>         select SH_INTC
>         select SYS_SUPPORTS_SH_TMU
>         select SYS_SUPPORTS_HUGETLBFS if MMU
> +       select UNCACHED_MAPPING
> +       select MMU

Selecting MMU is never the correct solution, as it's a platform feature.
Making something depend on MMU is something different, but I doubt
SH4 can only work with a MMU, cfr. the "if MMU" in the line above.

Back to the drawing board...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/