lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 2 Sep 2014 09:49:54 -0700 From: Bryan Wu <cooloney@...il.com> To: Josh Boyer <jwboyer@...oraproject.org> Cc: Jiri Kosina <jkosina@...e.cz>, Vincent Donnefort <vdonnefort@...il.com>, Linus Torvalds <torvalds@...ux-foundation.org>, Hugh Dickins <hughd@...gle.com>, Tejun Heo <tj@...nel.org>, "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] Revert "leds: convert blink timer to workqueue" On Tue, Sep 2, 2014 at 8:55 AM, Josh Boyer <jwboyer@...oraproject.org> wrote: > On Tue, Sep 2, 2014 at 5:03 AM, Jiri Kosina <jkosina@...e.cz> wrote: >> This reverts commit 8b37e1bef5a6b60e949e28a4db3006e4b00bd758. >> >> It's broken as it changes led_blink_set() in a way that it can now sleep >> (while synchronously waiting for workqueue to be cancelled). That's a >> problem, because it's possible that this function gets called from atomic >> context (tpt_trig_timer() takes a readlock and thus disables preemption). >> >> This has been brought up 3 weeks ago already [1] but no proper fix has >> materialized, and I keep seeing the problem since 3.18-rc1. >> >> [1] https://lkml.org/lkml/2014/8/16/128 > > FWIW we're seeing it reported in Fedora too. Perhaps a revert is the > right approach for now. > I'm going to apply this patch and will send it out for Linus soon. Thanks, -Bryan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists