linux-kernel - Re: [PATCH] init/Kconfig: move RCU_NOCB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABv5NL8mAy6CRbJQQx=su_72C_Sj-A+OFUA8nN1JPwmX_xeyKA@mail.gmail.com>
Date:	Tue, 2 Sep 2014 20:05:48 +0200
From:	Stefan Hengelein <stefan.hengelein@....de>
To:	paulmck@...ux.vnet.ibm.com
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	jkosina@...e.cz, paul.gortmaker@...driver.com, mhocko@...e.cz,
	mattst88@...il.com, josh@...htriplett.org, geert@...ux-m68k.org,
	khilman@...aro.org, Andreas Ruprecht <rupran@...server.de>
Subject: Re: [PATCH] init/Kconfig: move RCU_NOCB_CPU dependencies to choice

2014-09-02 19:07 GMT+02:00 Paul E. McKenney <paulmck@...ux.vnet.ibm.com>:
> On Fri, Aug 29, 2014 at 03:08:20PM +0200, Stefan Hengelein wrote:
>> Every choice item of the "Build-forced no-CBs CPUs" choice had a
>> dependency to RCU_NOCB_CPU. It's more comprehensible if the choice
>> itself has the dependency instead of every choice item.
>> The choice itself doesn't need to be visible if there are no items
>> selectable (i.e. on arch/frv) or RCU_NOCB_CPU is not defined.
>>
>> Signed-off-by: Stefan Hengelein <stefan.hengelein@....de>
>> Signed-off-by: Andreas Ruprecht <rupran@...server.de>
>
> Looks like a nice improvement, but could you please forward-port to branch
> rcu/dev of git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git?
>
>                                                                 Thanx, Paul

done, i attached the adjusted patch.

Best Regards,
Stefan

>
>> ---
>>  init/Kconfig | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/init/Kconfig b/init/Kconfig
>> index 197b563..d604000 100644
>> --- a/init/Kconfig
>> +++ b/init/Kconfig
>> @@ -729,6 +729,7 @@ config RCU_NOCB_CPU
>>  choice
>>       prompt "Build-forced no-CBs CPUs"
>>       default RCU_NOCB_CPU_NONE
>> +     depends on RCU_NOCB_CPU
>>       help
>>         This option allows no-CBs CPUs (whose RCU callbacks are invoked
>>         from kthreads rather than from softirq context) to be specified
>> @@ -737,7 +738,7 @@ choice
>>
>>  config RCU_NOCB_CPU_NONE
>>       bool "No build_forced no-CBs CPUs"
>> -     depends on RCU_NOCB_CPU && !NO_HZ_FULL_ALL
>> +     depends on !NO_HZ_FULL_ALL
>>       help
>>         This option does not force any of the CPUs to be no-CBs CPUs.
>>         Only CPUs designated by the rcu_nocbs= boot parameter will be
>> @@ -751,7 +752,7 @@ config RCU_NOCB_CPU_NONE
>>
>>  config RCU_NOCB_CPU_ZERO
>>       bool "CPU 0 is a build_forced no-CBs CPU"
>> -     depends on RCU_NOCB_CPU && !NO_HZ_FULL_ALL
>> +     depends on !NO_HZ_FULL_ALL
>>       help
>>         This option forces CPU 0 to be a no-CBs CPU, so that its RCU
>>         callbacks are invoked by a per-CPU kthread whose name begins
>> @@ -766,7 +767,6 @@ config RCU_NOCB_CPU_ZERO
>>
>>  config RCU_NOCB_CPU_ALL
>>       bool "All CPUs are build_forced no-CBs CPUs"
>> -     depends on RCU_NOCB_CPU
>>       help
>>         This option forces all CPUs to be no-CBs CPUs.  The rcu_nocbs=
>>         boot parameter will be ignored.  All CPUs' RCU callbacks will
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
>>
>

View attachment "0001-init-Kconfig-move-RCU_NOCB_CPU-dependencies-to-choic.patch" of type "text/x-patch" (2070 bytes)