linux-kernel - Re: [PATCH RFC 0/6] LLVMLinux: Patches to enable the kernel to be compiled with clang/LLVM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 02 Sep 2014 16:07:24 -0700
From:	Behan Webster <behanw@...verseincode.com>
To:	Marcel Holtmann <marcel@...tmann.org>
CC:	Alasdair Kergon <agk@...hat.com>, clm@...com,
	"David S. Miller" <davem@...emloft.net>, dm-devel@...hat.com,
	Fabian Frederick <fabf@...net.be>,
	Herbert Xu <herbert@...dor.apana.org.au>, jbacik@...com,
	snitzer@...hat.com, Andrew Morton <akpm@...ux-foundation.org>,
	james.l.morris@...cle.com, john.johansen@...onical.com,
	linux-btrfs@...r.kernel.org, linux-crypto@...r.kernel.org,
	kernel list <linux-kernel@...r.kernel.org>,
	linux-raid@...r.kernel.org, linux-security-module@...r.kernel.org,
	neilb@...e.de, serge@...lyn.com,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH RFC 0/6] LLVMLinux: Patches to enable the kernel to be
 compiled with clang/LLVM

On 09/02/14 16:01, Marcel Holtmann wrote:
> Hi Behan,
>
>> These patches remove the use of Variable Length Arrays In Structs (VLAIS) in
>> crypto related code. Presented here for comments as a whole (since they all do
>> the same thing in the same way). Once everyone is happy I will submit them
>> individually to their appropriate maintainers.
>>
>> The LLVMLinux project aims to fully build the Linux kernel using both gcc and
>> clang (the C front end for the LLVM compiler infrastructure project).
>>
>>
>> Jan-Simon Möller (4):
>>   crypto, dm: LLVMLinux: Remove VLAIS usage from dm-crypt
>>   crypto: LLVMLinux: Remove VLAIS usage from crypto/hmac.c
>>   crypto: LLVMLinux: Remove VLAIS usage from libcrc32c.c
>>   crypto: LLVMLinux: Remove VLAIS usage from crypto/testmgr.c
>>
>> Vinícius Tinti (2):
>>   apparmor: LLVMLinux: Remove VLAIS
>>   btrfs: LLVMLinux: Remove VLAIS
>>
>> crypto/hmac.c              | 27 +++++++++++++--------------
>> crypto/testmgr.c           | 16 ++++++++--------
>> drivers/md/dm-crypt.c      | 38 ++++++++++++++++++--------------------
>> fs/btrfs/hash.c            | 18 +++++++++---------
>> lib/libcrc32c.c            | 18 +++++++++---------
>> security/apparmor/crypto.c | 19 +++++++++----------
>> 6 files changed, 66 insertions(+), 70 deletions(-)
> are you sure these are all of them? I know for a fact that we are using the same construct in net/bluetooth/amp.c as well.
There have been other places where this was an issue before too (ext4, 
mac80211, USB gadget, ...). Some have already been fixed.

Hmm. Yeah, I thought we had a patch for bluetooth too. I can't find it 
now though.

Suffice it to say that similar patches are required for the other 
instances of this kind of code elsewhere as well.

Thanks Marcel,

Behan

-- 
Behan Webster
behanw@...verseincode.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/