lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 4 Sep 2014 00:53:25 +0200 From: Frans Klaver <fransklaver@...il.com> To: Corentin Chary <corentin.chary@...il.com> Cc: Frans Klaver <fransklaver@...il.com>, Matthew Garrett <matthew.garrett@...ula.com>, acpi4asus-user@...ts.sourceforge.net, platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH] eeepc-laptop: remove possible use of uninitialized value In store_sys_acpi, if count equals zero, or parse_arg()s sscanf call fails, 'value' remains possibly uninitialized. In that case 'value' shouldn't be used to produce the store_sys_acpi()s return value. Only test the return value of set_acpi() if we can actually call it. Return rv otherwise. Signed-off-by: Frans Klaver <fransklaver@...il.com> --- drivers/platform/x86/eeepc-laptop.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c index bd533c2..41f12ba 100644 --- a/drivers/platform/x86/eeepc-laptop.c +++ b/drivers/platform/x86/eeepc-laptop.c @@ -279,10 +279,10 @@ static ssize_t store_sys_acpi(struct device *dev, int cm, int rv, value; rv = parse_arg(buf, count, &value); - if (rv > 0) - value = set_acpi(eeepc, cm, value); - if (value < 0) - return -EIO; + if (rv > 0) { + if (set_acpi(eeepc, cm, value) < 0) + return -EIO; + } return rv; } -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists