linux-kernel - Re: [PATCH] usb: gadget: USB_RENESAS_USBHS_UDC should depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5406AEDB.2040702@renesas.com>
Date:	Wed, 3 Sep 2014 15:02:03 +0900
From:	Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Felipe Balbi <balbi@...com>,
	kuninori morimoto <kuninori.morimoto.gx@...esas.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: gadget: USB_RENESAS_USBHS_UDC should depend on HAS_DMA

Hi Geert,

(2014/08/30 4:31), Geert Uytterhoeven wrote:
> If NO_DMA=y:
> 
> drivers/built-in.o: In function `usbhsg_dma_map_ctrl':
> mod_gadget.c:(.text+0x53b226): undefined reference to `usb_gadget_map_request'
> mod_gadget.c:(.text+0x53b242): undefined reference to `usb_gadget_unmap_request'
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
>  drivers/usb/gadget/udc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig
> index 5151f947a4f5..00171d436cf8 100644
> --- a/drivers/usb/gadget/udc/Kconfig
> +++ b/drivers/usb/gadget/udc/Kconfig
> @@ -163,7 +163,7 @@ config USB_R8A66597
>  
>  config USB_RENESAS_USBHS_UDC
>  	tristate 'Renesas USBHS controller'
> -	depends on USB_RENESAS_USBHS
> +	depends on USB_RENESAS_USBHS && HAS_DMA
>  	help
>  	   Renesas USBHS is a discrete USB host and peripheral controller chip
>  	   that supports both full and high speed USB 2.0 data transfers.
> 

Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>

Best regards,
Yoshihiro Shimoda

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/