linux-kernel - Re: [PATCH] clk: at91: fix num_parents test in at91sam9260 slow clk implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140903094250.0a5b5154@bbrezillon>
Date:	Wed, 3 Sep 2014 09:42:50 +0200
From:	Boris BREZILLON <boris.brezillon@...e-electrons.com>
To:	Mike Turquette <mturquette@...aro.org>
Cc:	"Nicolas Ferre" <nicolas.ferre@...el.com>,
	"Jean-Christophe Plagniol-Villard" <plagnioj@...osoft.com>,
	"Alexandre Belloni" <alexandre.belloni@...e-electrons.com>,
	"Andrew Victor" <linux@...im.org.za>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: at91: fix num_parents test in at91sam9260 slow clk
 implementation

On Tue, 02 Sep 2014 14:45:06 -0700
Mike Turquette <mturquette@...aro.org> wrote:

> Quoting Boris BREZILLON (2014-09-02 08:27:51)
> > The slow clk block provided by at91sam9260 and derived SoCs should always
> > have 2 parents.
> > 
> > Signed-off-by: Boris BREZILLON <boris.brezillon@...e-electrons.com>
> > ---
> > 
> > Hello Mike,
> > 
> > Could you take this fix for the next 3.17 rc ?
> > Without this fix you won't be able to use programmable clks (the slow
> > clk is one of the parents of prog clks), and these prog clks are used,
> > among other things, to provide clks to external audio chips.
> > 
> > No need to backport this fix to previous stable releases, as CCF support
> > for at91sam9260 (and derived) SoCs only appeared in 3.17.
> 
> Pulled into clk-fixes.

Thanks!

> 
> Regards,
> Mike
> 
> > 
> > Best Regards,
> > 
> > Boris
> > 
> >  drivers/clk/at91/clk-slow.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/clk/at91/clk-slow.c b/drivers/clk/at91/clk-slow.c
> > index 0300c46..32f7c1b 100644
> > --- a/drivers/clk/at91/clk-slow.c
> > +++ b/drivers/clk/at91/clk-slow.c
> > @@ -447,7 +447,7 @@ void __init of_at91sam9260_clk_slow_setup(struct device_node *np,
> >         int i;
> >  
> >         num_parents = of_count_phandle_with_args(np, "clocks", "#clock-cells");
> > -       if (num_parents <= 0 || num_parents > 1)
> > +       if (num_parents != 2)
> >                 return;
> >  
> >         for (i = 0; i < num_parents; ++i) {
> > -- 
> > 1.9.1
> > 



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/