linux-kernel - RE: [PATCHv2 3/4] ASoC: simple-card: Adjust the comments of simple card.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <37e5ba204cb340bc9fe01b7473721a9d@BY2PR0301MB0613.namprd03.prod.outlook.com>
Date:	Wed, 3 Sep 2014 01:55:38 +0000
From:	"Li.Xiubo@...escale.com" <Li.Xiubo@...escale.com>
To:	Jean-Francois Moine <moinejf@...e.fr>
CC:	"broonie@...nel.org" <broonie@...nel.org>,
	"perex@...ex.cz" <perex@...ex.cz>,
	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	"tiwai@...e.de" <tiwai@...e.de>, "andrew@...n.ch" <andrew@...n.ch>,
	"kuninori.morimoto.gx@...esas.com" <kuninori.morimoto.gx@...esas.com>,
	"jsarha@...com" <jsarha@...com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"pawel.moll@....com" <pawel.moll@....com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	"galak@...eaurora.org" <galak@...eaurora.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCHv2 3/4] ASoC: simple-card: Adjust the comments of simple
 card.

> Subject: Re: [PATCHv2 3/4] ASoC: simple-card: Adjust the comments of simple
> card.
> 
> On Tue, 2 Sep 2014 17:26:08 +0800
> Xiubo Li <Li.Xiubo@...escale.com> wrote:
> 
> > @@ -285,11 +287,11 @@ static int asoc_simple_card_dai_link_of(struct
> device_node *node,
> >  		dai_props->codec_dai.sysclk);
> >
> >  	/*
> > -	 * soc_bind_dai_link() will check cpu name
> > -	 * after of_node matching if dai_link has cpu_dai_name.
> > -	 * but, it will never match if name was created by fmt_single_name()
> > -	 * remove cpu_dai_name to escape name matching.
> > -	 * see
> > +	 * In soc_bind_dai_link() will check cpu name after
> > +	 * of_node matching if dai_link has cpu_dai_name.
> > +	 * but, it will never match if name was created by
> > +	 * fmt_single_name() remove cpu_dai_name to escape
> > +	 * name matching. Please see:
> >  	 *	fmt_single_name()
> >  	 *	fmt_multiple_name()
> >  	 */
> 
> The patch done by Kuninori, setting the cpu_dai_name to NULL in all
> cases, does not work. This sequence should be replaced where is was
> previously.
> 

If so, it should be another issue here, should we send another patch for
It ?


Thanks,

BRs
Xiubo