linux-kernel - Re: [PATCH v4] staging: unisys: uislib: uisqueue.c: rewrite of do_locked_client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140903095950.GF6600@mwanda>
Date:	Wed, 3 Sep 2014 12:59:50 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Sudip Mukherjee <sudip@...torindia.org>
Cc:	Benjamin Romer <benjamin.romer@...sys.com>,
	David Kershner <david.kershner@...sys.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, sparmaintainer@...sys.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] staging: unisys: uislib: uisqueue.c: rewrite of
 do_locked_client_insert

On Wed, Sep 03, 2014 at 02:59:21PM +0530, Sudip Mukherjee wrote:
> 1) removed unused variables
> 2) fixed sparse warning of context imbalance in 'do_locked_client_insert'
>                          different lock contexts for basic block
> 3) removed the call to visor_signalqueue_empty() , this function is
>    checking whether a signal queue is empty, but the return value
>    of the function is not beeing used, so it is safe to remove.
> 
> Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>

Looks good.  Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/