linux-kernel - Re: [PATCH 4/5] Clocksource: Flextimer: Fix counter clock prescaler calculation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1409031257520.3333@nanos>
Date:	Wed, 3 Sep 2014 12:59:50 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Xiubo Li <Li.Xiubo@...escale.com>
cc:	daniel.lezcano@...aro.org, dongsheng.wang@...escale.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] Clocksource: Flextimer: Fix counter clock prescaler
 calculation.

On Tue, 26 Aug 2014, Xiubo Li wrote:

> We should minus one after calculating the counter input clock's
> prescaler.

And that's a complete useless changelog.

A) It lacks a proper description of the problem

B) It lacks a proper argument WHY we must decrement the prescaler
   value

   Hint: I used the verb "must" instead of "should". Can you figure
   out why?

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/