linux-kernel - Re: [PATCH] x86, lpc, Allow only one load of lpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140903123606.GG28985@lee--X1>
Date:	Wed, 3 Sep 2014 13:36:06 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Prarit Bhargava <prarit@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Peter Tyser <ptyser@...-inc.com>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH] x86, lpc, Allow only one load of lpc_ich

> > If only one is useful, why have the second one in the first place?
> 
> That's just it -- it shouldn't have been exposed (again, according to Intel).

I didn't mean at an OS level, I mean what's the point of having two on
the h/w.  I guess only Intel may know.

> > If the devices are present and we can see them, why not have 2?  Some
> > users might find a use for them.
> 
> No one will.

Okay, I guess I have my hackers head on here.  Perhaps this guy
shouldn't probe.  It just seems weird to have a device that we know
about and have register access to, but we're specifying "no playing".

> > In the WARNING you submitted only sysfs was having a hard time.
> > Perhaps the real fix would be to allow the Watchdog and GPIO driver to
> > change their name when registering, so they can each have their own
> > sysfs entries.
> 
> /me scratches head.
> 
> How does that help having multiple devices which shouldn't be exposed?

The fact that they shouldn't be exposed should be neither here nor
there.  I'm thinking that they are exposed, so why suffocate them.
Besides, what happens when there is a use-case for two of these
devices?

How are these guys being registered anyway?  Does PCI detect and
register them automatically?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/