[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1409748660.21827.55.camel@dhcp-9-2-203-236.watson.ibm.com>
Date: Wed, 03 Sep 2014 08:51:00 -0400
From: Mimi Zohar <zohar@...ux.vnet.ibm.com>
To: Dmitry Kasatkin <d.kasatkin@...sung.com>
Cc: linux-ima-devel@...ts.sourceforge.net,
linux-security-module@...r.kernel.org,
linux-kernel@...r.kernel.org, dmitry.kasatkin@...il.com
Subject: Re: [PATCH 2/8] integrity: remove declaration of non-existing
functions
On Wed, 2014-09-03 at 10:19 +0300, Dmitry Kasatkin wrote:
> Noticed that there are declaration of few non-existing functions.
> Also remove duplicated declaration of inegrity_iint_find().
Please include the commits, which removed these functions, in the patch
description.
Mimi
>
> Signed-off-by: Dmitry Kasatkin <d.kasatkin@...sung.com>
> ---
> security/integrity/ima/ima.h | 9 ---------
> security/integrity/integrity.h | 1 -
> 2 files changed, 10 deletions(-)
>
> diff --git a/security/integrity/ima/ima.h b/security/integrity/ima/ima.h
> index 0fb456c..c6990a7 100644
> --- a/security/integrity/ima/ima.h
> +++ b/security/integrity/ima/ima.h
> @@ -90,10 +90,7 @@ extern struct list_head ima_measurements; /* list of all measurements */
>
> /* Internal IMA function definitions */
> int ima_init(void);
> -void ima_cleanup(void);
> int ima_fs_init(void);
> -void ima_fs_cleanup(void);
> -int ima_inode_alloc(struct inode *inode);
> int ima_add_template_entry(struct ima_template_entry *entry, int violation,
> const char *op, struct inode *inode,
> const unsigned char *filename);
> @@ -151,12 +148,6 @@ int ima_store_template(struct ima_template_entry *entry, int violation,
> void ima_free_template_entry(struct ima_template_entry *entry);
> const char *ima_d_path(struct path *path, char **pathbuf);
>
> -/* rbtree tree calls to lookup, insert, delete
> - * integrity data associated with an inode.
> - */
> -struct integrity_iint_cache *integrity_iint_insert(struct inode *inode);
> -struct integrity_iint_cache *integrity_iint_find(struct inode *inode);
> -
> /* IMA policy related functions */
> enum ima_hooks { FILE_CHECK = 1, MMAP_CHECK, BPRM_CHECK, MODULE_CHECK, FIRMWARE_CHECK, POST_SETATTR };
>
> diff --git a/security/integrity/integrity.h b/security/integrity/integrity.h
> index 904e68a..c0379d1 100644
> --- a/security/integrity/integrity.h
> +++ b/security/integrity/integrity.h
> @@ -117,7 +117,6 @@ struct integrity_iint_cache {
> /* rbtree tree calls to lookup, insert, delete
> * integrity data associated with an inode.
> */
> -struct integrity_iint_cache *integrity_iint_insert(struct inode *inode);
> struct integrity_iint_cache *integrity_iint_find(struct inode *inode);
>
> #define INTEGRITY_KEYRING_EVM 0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists