linux-kernel - Re: [PATCH v2] mfd: syscon: Decouple syscon interface from platform devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140903161528.05f566e1@bbrezillon>
Date:	Wed, 3 Sep 2014 16:15:28 +0200
From:	Boris BREZILLON <boris.brezillon@...e-electrons.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Pankaj Dubey <pankaj.dubey@...sung.com>, kgene.kim@...sung.com,
	linux@....linux.org.uk, Alexander Shiyan <shc_work@...l.ru>,
	naushad@...sung.com, Tomasz Figa <t.figa@...sung.com>,
	linux-kernel@...r.kernel.org, joshi@...sung.com,
	linux-samsung-soc@...r.kernel.org, thomas.ab@...sung.com,
	tomasz.figa@...il.com, vikas.sajjan@...sung.com,
	chow.kim@...sung.com, lee.jones@...aro.org,
	Michal Simek <michal.simek@...inx.com>,
	linux-arm-kernel@...ts.infradead.org,
	Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH v2] mfd: syscon: Decouple syscon interface from platform
 devices

On Wed, 03 Sep 2014 15:49:04 +0200
Arnd Bergmann <arnd@...db.de> wrote:

> On Wednesday 03 September 2014 15:16:11 Boris BREZILLON wrote:
> > I checked that part, and it appears most of the code is already there
> > (see usage of regmap_attach_dev function here [1]).
> > 
> > The only problem I see is that errors are still printed with dev_err,
> > which, AFAIK, will trigger a kernel panic if dev is NULL.
> 
> Actually not:
> 
> static int __dev_printk(const char *level, const struct device *dev,
>                         struct va_format *vaf)
> {
>         if (!dev)
>                 return printk("%s(NULL device *): %pV", level, vaf);
> 
>         return dev_printk_emit(level[1] - '0', dev,
>                                "%s %s: %pV",
>                                dev_driver_string(dev), dev_name(dev), vaf);
> }
> 

My bad then (I don't know where I looked at to think NULL dev was not
gracefully handled :-)). Thanks for pointing this out.
Given that, I think it should work fine even with a NULL dev.
I'll give it a try on at91 ;-).

Best Regards,

Boris

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/