lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Wed, 3 Sep 2014 20:22:04 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Piotr Witoslawski <pwitos@...il.com>
Cc:	lidza.louina@...il.com, driverdev-devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org, markh@...pro.net
Subject: Re: [PATCH] drivers: staging: dgap: fix the checkpatch.pl issue
 "Warning: line over 80 characters"

On Wed, Sep 03, 2014 at 04:09:59PM +0200, Piotr Witoslawski wrote:
> Done as Eudyptula task 10.
use proper commit message mentioning what changes you have done. 
and you have not sent the patch to all the people who were
supposed to be sent. 

thanks
sudip

> Signed-off-by: Piotr Witoslawski <pwitos@...il.com>
> ---
>  drivers/staging/dgap/dgap.c | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
> index 8929dbf..67da1d5 100644
> --- a/drivers/staging/dgap/dgap.c
> +++ b/drivers/staging/dgap/dgap.c
> @@ -88,7 +88,8 @@ static int dgap_block_til_ready(struct tty_struct *tty, struct file *file,
>  				struct channel_t *ch);
>  static int dgap_tty_ioctl(struct tty_struct *tty, unsigned int cmd,
>  				unsigned long arg);
> -static int dgap_tty_digigeta(struct channel_t *ch, struct digi_t __user *retinfo);
> +static int dgap_tty_digigeta(struct channel_t *ch,
> +			     struct digi_t __user *retinfo);
>  static int dgap_tty_digiseta(struct channel_t *ch, struct board_t *bd,
>  			     struct un_t *un, struct digi_t __user *new_info);
>  static int dgap_tty_digigetedelay(struct tty_struct *tty, int __user *retinfo);
> @@ -104,8 +105,9 @@ static void dgap_tty_flush_chars(struct tty_struct *tty);
>  static void dgap_tty_flush_buffer(struct tty_struct *tty);
>  static void dgap_tty_hangup(struct tty_struct *tty);
>  static int dgap_wait_for_drain(struct tty_struct *tty);
> -static int dgap_set_modem_info(struct channel_t *ch, struct board_t *bd, struct un_t *un,
> -			       unsigned int command, unsigned int __user *value);
> +static int dgap_set_modem_info(struct channel_t *ch, struct board_t *bd,
> +			       struct un_t *un, unsigned int command,
> +			       unsigned int __user *value);
>  static int dgap_get_modem_info(struct channel_t *ch,
>  				unsigned int __user *value);
>  static int dgap_tty_digisetcustombaud(struct channel_t *ch, struct board_t *bd,
> @@ -3076,8 +3078,9 @@ static int dgap_get_modem_info(struct channel_t *ch, unsigned int __user *value)
>   *
>   * Set modem signals, called by ld.
>   */
> -static int dgap_set_modem_info(struct channel_t *ch, struct board_t *bd, struct un_t *un,
> -			       unsigned int command, unsigned int __user *value)
> +static int dgap_set_modem_info(struct channel_t *ch, struct board_t *bd,
> +			       struct un_t *un, unsigned int command,
> +			       unsigned int __user *value)
>  {
>  	int ret;
>  	unsigned int arg;
> @@ -3153,7 +3156,8 @@ static int dgap_set_modem_info(struct channel_t *ch, struct board_t *bd, struct
>   *
>   *
>   */
> -static int dgap_tty_digigeta(struct channel_t *ch, struct digi_t __user *retinfo)
> +static int dgap_tty_digigeta(struct channel_t *ch,
> +			     struct digi_t __user *retinfo)
>  {
>  	struct digi_t tmp;
>  	ulong lock_flags;
> -- 
> 1.8.5.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ