linux-kernel - [PATCH] drivers/target/target_core_transport.c: Fix typo issue to use 'buf' instead of 'len'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 03 Sep 2014 23:33:50 +0800
From:	Chen Gang <gang.chen.5i5j@...il.com>
To:	nab@...ux-iscsi.org
CC:	linux-scsi@...r.kernel.org, target-devel@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Michal Simek <monstr@...str.eu>
Subject: [PATCH] drivers/target/target_core_transport.c: Fix typo issue to
 use 'buf' instead of 'len'

It is a typo issue, need use 'buf' instead of 'len', the related warning
with allmodconfig under microblaze:

drivers/target/target_core_transport.c: In function ‘transport_dump_vpd_ident_type’:
drivers/target/target_core_transport.c:956:9: warning: passing argument 1 of ‘strlen’ makes pointer from integer without a cast
   len = strlen(len);
         ^
In file included from include/linux/bitmap.h:8:0,
                 from include/linux/cpumask.h:11,
                 from include/linux/mm_types.h:12,
                 from include/linux/kmemcheck.h:4,
                 from include/linux/net.h:25,
                 from drivers/target/target_core_transport.c:26:
include/linux/string.h:83:24: note: expected ‘const char *’ but argument is of type ‘int’
 extern __kernel_size_t strlen(const char *);
                        ^

Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com>
---
 drivers/target/target_core_transport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index 1dd1181..3ce85ed 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -953,7 +953,7 @@ int transport_dump_vpd_ident_type(
 		strlcat(buf, "SCSI name string\n", sizeof(buf));
 		break;
 	default:
-		len = strlen(len);
+		len = strlen(buf);
 		snprintf(&buf[len], sizeof(buf) - len, "Unsupported: 0x%02x\n",
 				vpd->device_identifier_type);
 		ret = -EINVAL;
-- 
1.9.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/