linux-kernel - Re: [PATCH 3/6] staging: goldfish: document spinlock usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140903162528.GA1733@iron>
Date:	Wed, 3 Sep 2014 18:25:28 +0200
From:	Loic Pefferkorn <loic@...cp.eu>
To:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
Cc:	gregkh@...uxfoundation.org, alan@...ux.intel.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] staging: goldfish: document spinlock usage

On Wed, Sep 03, 2014 at 01:13:19PM +0100, One Thousand Gnomes wrote:
> 
> This tells the reader nothing. It's good to document locking models but
> 
> - you lock data not code (which is a detail a lot of programmers get wrong
> 			  in th design stage too)
> - you need to document what objects are protected by the lock
> 
> 
> So it should tell the reader what the lock must be held to do
> 
> If you look at the audio code it actually protects the status field and
> status register of the "hardware"

Hello,

Thank you for the feedback, I will send a v2.

-- 
Cheers,
Loïc
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/