linux-kernel - RE: [PATCH 00/37] staging: comedi: rename command flags for consistency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DC148C5AA1CEBA4E87973D432B1C2D8825F8640B@P3PWEX4MB008.ex4.secureserver.net>
Date:	Wed, 3 Sep 2014 17:26:13 +0000
From:	Hartley Sweeten <HartleyS@...ionengravers.com>
To:	Ian Abbott <abbotti@....co.uk>,
	"driverdev-devel@...uxdriverproject.org" 
	<driverdev-devel@...uxdriverproject.org>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 00/37] staging: comedi: rename command flags for
 consistency

On Wednesday, September 03, 2014 5:45 AM, Ian Abbott wrote:
>
> The various macros in "comedi.h" used to construct values for the
> `flags` member of `struct comedi_cmd` are named inconsistently.  Some of
> the macros with the `TRIG_` prefix are from a long defunct Comedi
> trigger interface that was replaced with the current Comedi asynchronous
> command interface many years ago, co-opting most of the `TRIG_` macros
> in the process.  Some of them are still used with various other members
> of `struct comedi_cmd` to select trigger sources.  Others are used with
> the `flags` member.  There are other macros for use with the command
> `flags` member using the prefix `CMDF_`, and some of the old `TRIG_`
> macros have been renamed already, keeping the old names around as
> synonyms for backwards compatibility.
>
> For consistency, rename the `TRIG_` prefixed macros used with the
> command `flags` member to use the prefix `CMDF_` and redefine the
> renamed macros as synonyms for backwards compatibilty.
>
> There are still some left-over `TRIG_` macros unused by the Comedi
> kernel code, but the user-space Comedilib library may still be trying to
> use them, so hang onto them for now.

Reviewed-by: H Hartley Sweeten <hsweeten@...ionengravers.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/