linux-kernel - Re: [PATCH 1/1] PWM Backlight: Fix a bug which could cause the PWM backlight driver use the wrong PWM chip and fail the driver probing if multiple PWM chips exist. This defect could also cause the unintended PWM chip used and unaccessable by other drivers. The patch will check the error state first and allow a deferral PWM backlight probing if the intended PWM driver is not loaded at the probing moment.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140904083958.GF8257@lee--X1>
Date:	Thu, 4 Sep 2014 09:39:58 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	ryang <hachyang@...il.com>
Cc:	thierry.reding@...il.com, jg1.han@...sung.com,
	linux-pwm@...r.kernel.org, ryang <ryang@...h.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] PWM Backlight: Fix a bug which could cause the PWM
 backlight driver use the wrong PWM chip and fail the driver probing if
 multiple PWM chips exist. This defect could also cause the unintended PWM
 chip  used and unaccessable by other drivers. The patch will check the error
 state first and allow a deferral PWM backlight probing if the intended PWM
 driver is not loaded at the probing moment.

> I'm guessing this is your first patch.
> 
> Please read: Documentation/SubmittingPatches
> 
> A few notes for you search for and read about in the above document.
> 
>  - Subject line formatting (short, succinct) 
>  - Commit logs (present, descriptive [what changed and why], succinct)
>  - Authorship (full/real names only)

You also need to CC linux-kernel@...r.kernel.org on all patches.

> > Signed-off-by: ryang <ryang@...h.com>
> > ---
> >  drivers/video/backlight/pwm_bl.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
> > index b85983e..e0014a5 100644
> > --- a/drivers/video/backlight/pwm_bl.c
> > +++ b/drivers/video/backlight/pwm_bl.c
> > @@ -273,6 +273,9 @@ static int pwm_backlight_probe(struct platform_device *pdev)
> >  
> >  	pb->pwm = devm_pwm_get(&pdev->dev, NULL);
> >  	if (IS_ERR(pb->pwm)) {
> > +		ret = PTR_ERR(pb->pwm);
> > +		if (ret == -EPROBE_DEFER)
> > +			goto err_alloc;
> >  		dev_err(&pdev->dev, "unable to request PWM, trying legacy API\n");
> >  
> >  		pb->pwm = pwm_request(data->pwm_id, "pwm-backlight");
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/