linux-kernel - Re: [PATCH] mfd: pcf50633: use sprintf directly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140904100503.GF1397@lee--X1>
Date:	Thu, 4 Sep 2014 11:05:03 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: pcf50633: use sprintf directly

On Thu, 04 Sep 2014, Andy Shevchenko wrote:

> When dump a content of the registers let's use snprintf() directly with %*ph
> specifier.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/mfd/pcf50633-core.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c
> index c87f7a0..8401552 100644
> --- a/drivers/mfd/pcf50633-core.c
> +++ b/drivers/mfd/pcf50633-core.c
> @@ -106,10 +106,7 @@ static ssize_t show_dump_regs(struct device *dev, struct device_attribute *attr,
>  			} else
>  				dump[n1] = pcf50633_reg_read(pcf, n + n1);
>  
> -		hex_dump_to_buffer(dump, sizeof(dump), 16, 1, buf1, 128, 0);
> -		buf1 += strlen(buf1);
> -		*buf1++ = '\n';
> -		*buf1 = '\0';
> +		buf1 += sprintf(buf1, "%*ph\n", (int)sizeof(dump), dump);
>  	}
>  
>  	return buf1 - buf;

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/