linux-kernel - Re: [PATCH v2 01/17] locks: consolidate "nolease" routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140904084938.2664bf0a@tlielax.poochiereds.net>
Date:	Thu, 4 Sep 2014 08:49:38 -0400
From:	Jeff Layton <jeff.layton@...marydata.com>
To:	Trond Myklebust <trond.myklebust@...marydata.com>
Cc:	Devel FS Linux <linux-fsdevel@...r.kernel.org>,
	Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
	Christoph Hellwig <hch@...radead.org>,
	"J. Bruce Fields" <bfields@...ldses.org>,
	Linux Kernel mailing list <linux-kernel@...r.kernel.org>,
	Steven Whitehouse <swhiteho@...hat.com>,
	cluster-devel <cluster-devel@...hat.com>
Subject: Re: [PATCH v2 01/17] locks: consolidate "nolease" routines

On Thu, 4 Sep 2014 08:41:51 -0400
Trond Myklebust <trond.myklebust@...marydata.com> wrote:

> On Thu, Sep 4, 2014 at 8:38 AM, Jeff Layton <jlayton@...marydata.com> wrote:
> > GFS2 and NFS have setlease routines that always just return -EINVAL.
> > Turn that into a generic routine that can live in fs/libfs.c.
> >
> > Cc: Trond Myklebust <trond.myklebust@...marydata.com>
> > Cc: <linux-nfs@...r.kernel.org>
> > Cc: Steven Whitehouse <swhiteho@...hat.com>
> > Cc: <cluster-devel@...hat.com>
> > Signed-off-by: Jeff Layton <jlayton@...marydata.com>
> > ---
> >  fs/gfs2/file.c     | 22 +---------------------
> >  fs/libfs.c         | 16 ++++++++++++++++
> >  fs/nfs/file.c      | 13 +------------
> >  fs/nfs/internal.h  |  1 -
> >  fs/nfs/nfs4file.c  |  2 +-
> >  include/linux/fs.h |  1 +
> >  6 files changed, 20 insertions(+), 35 deletions(-)
> 
> Acked-by: Trond Myklebust <trond.myklebust@...marydata.com>
> 

Thanks. While spinning this up, I did have a momentary pause to wonder
if -ENOLCK would be a better return value here.

It would make it easier to distinguish this from from "oops, I passed
in bogus arguments". For now, I'll leave it as -EINVAL, but it's
something to consider...

-- 
Jeff Layton <jlayton@...marydata.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/