lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 4 Sep 2014 17:26:58 +0300 From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> To: Tadeusz Struk <tadeusz.struk@...el.com>, Herbert Xu <herbert@...dor.apana.org.au>, Mauro Carvalho Chehab <m.chehab@...sung.com>, Helge Deller <deller@....de>, Ingo Tuchscherer <ingo.tuchscherer@...ibm.com>, Alexander Viro <viro@...iv.linux.org.uk>, linux-kernel@...r.kernel.org, Joe Perches <joe@...ches.com>, Marek Vasut <marex@...x.de>, Geert Uytterhoeven <geert@...ux-m68k.org>, Vladimir Kondratiev <qca_vkondrat@....qualcomm.com>, Benjamin Romer <benjamin.romer@...sys.com>, Catalin Marinas <catalin.marinas@....com>, Randy Dunlap <rdunlap@...radead.org> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Subject: [PATCH v4 11/12] kmemleak: use seq_hex_dump() to dump buffers Instead of custom approach let's use recently introduced seq_hex_dump() helper. Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> --- mm/kmemleak.c | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/mm/kmemleak.c b/mm/kmemleak.c index 3cda50c..bc14fdc 100644 --- a/mm/kmemleak.c +++ b/mm/kmemleak.c @@ -291,23 +291,14 @@ static void hex_dump_object(struct seq_file *seq, struct kmemleak_object *object) { const u8 *ptr = (const u8 *)object->pointer; - int i, len, remaining; - unsigned char linebuf[HEX_ROW_SIZE * 5]; + size_t len; /* limit the number of lines to HEX_MAX_LINES */ - remaining = len = - min(object->size, (size_t)(HEX_MAX_LINES * HEX_ROW_SIZE)); - - seq_printf(seq, " hex dump (first %d bytes):\n", len); - for (i = 0; i < len; i += HEX_ROW_SIZE) { - int linelen = min(remaining, HEX_ROW_SIZE); - - remaining -= HEX_ROW_SIZE; - hex_dump_to_buffer(ptr + i, linelen, HEX_ROW_SIZE, - HEX_GROUP_SIZE, linebuf, sizeof(linebuf), - HEX_ASCII); - seq_printf(seq, " %s\n", linebuf); - } + len = min(object->size, (size_t)(HEX_MAX_LINES * HEX_ROW_SIZE)); + + seq_printf(seq, " hex dump (first %zu bytes):\n", len); + seq_hex_dump(seq, " ", DUMP_PREFIX_NONE, HEX_ROW_SIZE, + HEX_GROUP_SIZE, ptr, len, HEX_ASCII); } /* -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists