linux-kernel - Re: [PATCH 1/2] sched: Add helper for task stack page overrun checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140904153047.GD346@worktop.programming.kicks-ass.net>
Date:	Thu, 4 Sep 2014 17:30:47 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Aaron Tomlin <atomlin@...hat.com>
Cc:	mingo@...hat.com, dzickus@...hat.com, bmr@...hat.com,
	jcastillo@...hat.com, oleg@...hat.com, pzijlstr@...hat.com,
	riel@...hat.com, linux-kernel@...r.kernel.org, tglx@...utronix.de,
	x86@...nel.org, rostedt@...dmis.org, hannes@...xchg.org,
	aneesh.kumar@...ux.vnet.ibm.com, akpm@...ux-foundation.org,
	linuxppc-dev@...ts.ozlabs.org, minchan@...nel.org
Subject: Re: [PATCH 1/2] sched: Add helper for task stack page overrun
 checking

On Thu, Sep 04, 2014 at 03:50:23PM +0100, Aaron Tomlin wrote:

> @@ -537,8 +535,8 @@ void bad_page_fault(struct pt_regs *regs, unsigned long address, int sig)
>  	printk(KERN_ALERT "Faulting instruction address: 0x%08lx\n",
>  		regs->nip);
>  
> -	stackend = end_of_stack(current);
> -	if (current != &init_task && *stackend != STACK_END_MAGIC)
> +	if (current != &init_task &&
> +		task_stack_end_corrupted(current))

superfluous linebreak.

> @@ -2614,6 +2615,8 @@ static inline unsigned long *end_of_stack(struct task_struct *p)
>  }
>  
>  #endif

Here otoh we could do with some extra whitespace

> @@ -171,8 +170,8 @@ check_stack(unsigned long ip, unsigned long *stack)
>  			i++;
>  	}
>  
> -	if ((current != &init_task &&
> -		*(end_of_stack(current)) != STACK_END_MAGIC)) {
> +	if (current != &init_task &&
> +		task_stack_end_corrupted(current)) {

Again, superfluous linebreak.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/