linux-kernel - Re: [PATCH] Staging: rtl8192u: fix brace style coding issue in r819xU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1409844750.2770.10.camel@joe-AO725>
Date:	Thu, 04 Sep 2014 08:32:30 -0700
From:	Joe Perches <joe@...ches.com>
To:	Chaitra Ramaiah <linux.delve@...il.com>
Cc:	gregkh@...uxfoundation.org, burzalodowa@...il.com,
	anarey@...il.com, rmfrfs@...il.com, gdonald@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8192u: fix brace style coding issue in
 r819xU_firmware.c

On Thu, 2014-09-04 at 20:41 +0530, Chaitra Ramaiah wrote:
[]
> diff --git a/drivers/staging/rtl8192u/r819xU_firmware.c b/drivers/staging/rtl8192u/r819xU_firmware.c
[]
> @@ -153,11 +153,10 @@ static bool CPUcheck_maincodeok_turnonCPU(struct net_device *dev)
>  			break;
>  	}while(check_bootOk_time--);
>  
> -	if (!(CPU_status&CPU_GEN_BOOT_RDY)) {
> +	if (!(CPU_status&CPU_GEN_BOOT_RDY))
>  		goto CPUCheckMainCodeOKAndTurnOnCPU_Fail;
> -	} else {
> +	else
>  		RT_TRACE(COMP_FIRMWARE, "Download Firmware: Boot ready!\n");
> -	}

This would be better as:

	if (!(CPU_status & CPU_GEN_BOOT_RDY))
		goto CPUCheckMainCodeOKandTurnOnCPU_Fail;

	RT_TRACE(etc...)

It'd be nice to eliminate the StudlyCaps and
rather long labels too.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/