linux-kernel - Re: [PATCH v8] usb:serial:pl2303: add GPIOs interface on PL2303

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZ35WTug2ZUN3-hqg9-BB59eHO+vzOsUE+C-yb+AEp2Zg@mail.gmail.com>
Date:	Thu, 4 Sep 2014 18:56:49 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Wang YanQing <udknight@...il.com>,
	Greg KH <gregkh@...uxfoundation.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Johan Hovold <jhovold@...il.com>, andi@...as.de,
	dforsi@...il.com, One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v8] usb:serial:pl2303: add GPIOs interface on PL2303

On Sun, Aug 31, 2014 at 5:24 PM, Wang YanQing <udknight@...il.com> wrote:

> PL2303 USB Serial devices may has GPIOs, this patch add
> basic PL2303 gpio support.
>
> Known issue:
> If gpios are in use(export to userspace through sysfs interface, etc),
> then call pl2303_release(unplug usb-serial convertor, modprobe -r, etc),
> will cause trouble, so we need to make sure there is no gpio user before
> call pl2303_release.
>
> Signed-off-by: Wang YanQing <udknight@...il.com>
> ---
>  Note: I sniffed office HXD gpio test program to get
>        gpios control protocol with PL2303 RA, so I only
>        test it with PL2303 RA and HXA, I don't have HXD,
>        but because it is *office* HXD gpio test program,
>        so if it doesn't work with HXD, I will feel surprise.
>
>  Changes
>  v7-v8:
>  1: add support for four dedicated gpios on HXD and RA
>  2: fix problem reported by Johan Hovold in v7
>  3: fix checkpatch.pl's warning

This has been looking nice from the GPIO side of things
for a while so:
Acked-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/