[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5407E096.5000005@huawei.com>
Date: Thu, 4 Sep 2014 11:46:30 +0800
From: xiakaixu <xiakaixu@...wei.com>
To: <linux-arm-kernel@...ts.infradead.org>
CC: Arnd Bergmann <arnd@...db.de>, Felix Fietkau <nbd@...nwrt.org>,
<linaro-kernel@...ts.linaro.org>,
Anton Vorontsov <anton@...msg.org>,
<linux-kernel@...r.kernel.org>, Imre Kaloz <kaloz@...nwrt.org>,
Xia Kaixu <kaixu.xia@...aro.org>
Subject: Re: [PATCH] ARM: cns3xxx: fix allmodconfig panic in pci driver
δΊ 2014/9/3 21:27, Arnd Bergmann ει:
> On Wednesday 03 September 2014 21:18:12 Xia Kaixu wrote:
>> From: Xia Kaixu <kaixu.xia@...aro.org>
>>
>> The kernel panic occurs when running an allmodconfig kernel on
>> OMAP4460. The inicall "cns3xxx_pcie_init" does not check which
>> hardware it's running on and just tries to access to its specific
>> registers. Now call it from .init_late callback from the two
>> machine descriptors.
>>
>> Signed-off-by: Xia Kaixu <kaixu.xia@...aro.org>
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> Cc: Anton Vorontsov <anton@...msg.org>
>> Cc: Felix Fietkau <nbd@...nwrt.org>
>> Cc: Imre Kaloz <kaloz@...nwrt.org>
>> Cc: linaro-kernel@...ts.linaro.org
>> Cc: linux-arm-kernel@...ts.infradead.org
>
> Hi Kaixu,
>
> it seems this time all the Cc's worked. One thing I just noticed is that
> you confused the 'Signed-off-by' lines. I did look at the patch earlier
> before you sent it out but unfortunately missed that.
>
> You can read again in Documentation/SubmittingPatches about how
> they work, but the short version is that you must never put someone
> else's name in Signed-off-by under a patch you write yourself.
> When we apply the patch, I (or whoever else does) will put that
> line below yours to document who handled the patch.
Sure, you are right. Thanks for the reminder!
>
> Otherwise, the patch looks good to me, thanks a lot for doing it.
>
> Arnd
>
> _______________________________________________
> linaro-kernel mailing list
> linaro-kernel@...ts.linaro.org
> http://lists.linaro.org/mailman/listinfo/linaro-kernel
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists