linux-kernel - Re: [PATCH] rtl8188eu: Replace rcu_dereference() with rcu_access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 4 Sep 2014 23:58:36 +0300
From:	Andreea Bernat <bernat.ada@...il.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Larry.Finger@...inger.net, Elena Oat <oat.elena@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Paul McKenney <paulmck@...ux.vnet.ibm.com>
Subject: Re: [PATCH] rtl8188eu: Replace rcu_dereference() with rcu_access_pointer()

Hello,

I cloned this:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git

and after moved to staging-next branch, but in both cases, in
those files I don't find any use of rcu_dereference() call (the call
which I am looking for to modify).

Thank you,
Andreea

2014-08-30 23:42 GMT+03:00 Greg KH <gregkh@...uxfoundation.org>:
> On Sun, Aug 17, 2014 at 02:43:37PM +0300, Andreea-Cristina Bernat wrote:
>> The "rcu_dereference()" call is used directly in a condition.
>> Since its return value is never dereferenced it is recommended to use
>> "rcu_access_pointer()" instead of "rcu_dereference()".
>> Therefore, this patch makes the replacement.
>>
>> The following Coccinelle semantic patch was used:
>> @@
>> @@
>>
>> (
>>  if(
>>  (<+...
>> - rcu_dereference
>> + rcu_access_pointer
>>   (...)
>>   ...+>)) {...}
>> |
>>  while(
>>  (<+...
>> - rcu_dereference
>> + rcu_access_pointer
>>   (...)
>>   ...+>)) {...}
>> )
>>
>> Signed-off-by: Andreea-Cristina Bernat <bernat.ada@...il.com>
>> ---
>>  drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> This patch fails to apply to my tree, can you refresh it against the
> staging-next branch of the staging.git tree on kernel.org and resend?
>
> thanks,
>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/